[meta-freescale] [meta-fsl-arm PATCH v2 5/5] Move mxs-base.inc contents to imx-base.inc

[Otavio Salvador]

On Thu, Sep 24, 2015 at 10:47 AM, Daiane Angolini <daiane.list at gmail.com> wrote:
> On Thu, Sep 24, 2015 at 9:32 AM, Otavio Salvador
> <otavio at ossystems.com.br> wrote:
>> The consolidation of all i.MX related base settings allow for a more
>> global view of the settings in place. Up to now, the i.MX 23 and i.MX
>> 28 SoCs were using the mxs-base.inc file, causing fragmentation.
>>
>> The changes necessary to keep all i.MX 23 and i.MX 28 reference boards
>> working properly has been done, some values need to be reworked to
>
> The consolidation of all i.MX related base settings allows a more
> global view of the settings in place.
>
> One of the causes of this patch is the fragmentation caused by i.MX23
> and i.MX28 SoCs using mxs-base.inc.
>
> The changes needed to get i.MX23 and i.MX28  SoCs working have been
> included in imx-base.inc file already, ...

I reworked this as:

---
The consolidation of all i.MX related base settings allows a more
global view of the settings in place.

One of the causes of this patch is the fragmentation caused by i.MX23
and i.MX28 SoCs using mxs-base.inc.

The changes needed to get i.MX23 and i.MX28 SoCs working have been
included in imx-base.inc file already and some values required rework
to apply to specific SoC families to avoid regressions.
---

Better?

>> apply to SoC families instead of global setting but the price for
>> clearness seems worth it.
>
> This piece I don't understand. Are additional changes needed for
> future (#FIXME)? Or you are still talking about the motivation of this
> patch?

No; just explaining there are changes to avoid regressions. I reworked
the commit log.

...
>> +UBOOT_MAKE_TARGET_mxs = "u-boot.sb"
>> +UBOOT_MAKE_TARGET_mx51 = "u-boot.imx"
>> +UBOOT_MAKE_TARGET_mx53 = "u-boot.imx"
>> +UBOOT_MAKE_TARGET_mx6 = "u-boot.imx"
>> +UBOOT_MAKE_TARGET_mx6sl = "u-boot.imx"
>> +UBOOT_MAKE_TARGET_mx6sx = "u-boot.imx"
>
> Why are you duplicating for sl and sx?
>
> I don't see imx6ul

My fault; I will expand it.

>> +UBOOT_MAKE_TARGET_mx7 = "u-boot.imx"
>> +UBOOT_MAKE_TARGET_vf = "u-boot.imx"
>> +
>> +UBOOT_SUFFIX_mxs = "sb"
>> +UBOOT_SUFFIX_mx51 = "imx"
>> +UBOOT_SUFFIX_mx53 = "imx"
>> +UBOOT_SUFFIX_mx6 = "imx"
>> +UBOOT_SUFFIX_mx6sl = "imx"
>> +UBOOT_SUFFIX_mx6sx = "imx"
>
> Why are you duplicating for sl and sx?
>
> I don't see imx6ul

Ditto.

>> +UBOOT_SUFFIX_mx7 = "imx"
>> +UBOOT_SUFFIX_vf = "imx"
>> +
>> +UBOOT_ENTRYPOINT_mxs = "0x40008000"
>>  UBOOT_ENTRYPOINT_mx51  = "0x90008000"
>>  UBOOT_ENTRYPOINT_mx53  = "0x70008000"
>>  UBOOT_ENTRYPOINT_mx6  = "0x10008000"
>> @@ -132,6 +149,7 @@ PREFERRED_PROVIDER_virtual/libg2d_mx6ul = ""
>>
>>  # Handle default kernel
>>  IMX_DEFAULT_KERNEL = "linux-imx"
>> +IMX_DEFAULT_KERNEL_mxs = "linux-fslc"
>>  IMX_DEFAULT_KERNEL_mx5 = "linux-fslc"
>>  IMX_DEFAULT_KERNEL_mx6 = "linux-fslc-mx6"
>>  IMX_DEFAULT_KERNEL_mx6ul = "linux-imx"
>> @@ -140,8 +158,16 @@ PREFERRED_PROVIDER_virtual/kernel ??= "${IMX_DEFAULT_KERNEL}"
>>
>>  SDCARD_ROOTFS ?= "${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ext4"
>>  IMAGE_FSTYPES ?= "ext4 sdcard.gz"
>> -
>> -SERIAL_CONSOLE = "115200 ttymxc0"
>> +IMAGE_FSTYPES_mxs ?= "ext4 uboot.mxsboot-sdcard sdcard.gz"
>> +
>> +SERIAL_CONSOLE_mxs = "115200 ttyAMA0"
>> +SERIAL_CONSOLE_mx51 = "115200 ttymxc0"
>> +SERIAL_CONSOLE_mx53 = "115200 ttymxc0"
>> +SERIAL_CONSOLE_mx6 = "115200 ttymxc0"
>> +SERIAL_CONSOLE_mx6sl = "115200 ttymxc0"
>> +SERIAL_CONSOLE_mx6sx = "115200 ttymxc0"
>> +SERIAL_CONSOLE_mx7 = "115200 ttymxc0"
>> +SERIAL_CONSOLE_vf = "115200 ttymxc0"
>
> Can you, please, explain why we cannot have SERIAL_CONSOLE any more
> and only override for mxs?

I will rework this.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750