[meta-freescale] [meta-fsl-arm PATCH v2 1/5] mxs-base.inc: Consolidate IMAGE_FSTYPES definition

Daiane Angolini daiane.list at gmail.com
Thu Sep 24 06:17:18 PDT 2015


On Thu, Sep 24, 2015 at 9:32 AM, Otavio Salvador
<otavio at ossystems.com.br> wrote:
> The IMAGE_FSTYPES should have a default that uses the SD Card class
> for image generation, using this all evaluation boards work out of box
> using the provided .sdcard image.

The default value for IMAGE_FSTYPES including SDCard class enable all
machine to work out of the box using the .sdcard image

> The duplicated definition has been removed, affected machines are:

The removed duplication affected the following machines

>
>  - imx23evk
>  - imx28evk

Your commit log is not bad, see if you like my suggestions. If not I
think it's not a problem if you use the original text

Daiane


>
> Signed-off-by: Otavio Salvador <otavio at ossystems.com.br>
> ---
>
> Changes in v2: None
>
>  conf/machine/imx23evk.conf        | 3 ---
>  conf/machine/imx28evk.conf        | 3 ---
>  conf/machine/include/mxs-base.inc | 3 +++
>  3 files changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/conf/machine/imx23evk.conf b/conf/machine/imx23evk.conf
> index ecaef9a..1d5eaef 100644
> --- a/conf/machine/imx23evk.conf
> +++ b/conf/machine/imx23evk.conf
> @@ -13,7 +13,4 @@ UBOOT_MACHINE = "mx23evk_config"
>
>  KERNEL_DEVICETREE = "imx23-evk.dtb"
>
> -SDCARD_ROOTFS ?= "${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ext3"
> -IMAGE_FSTYPES ?= "tar.bz2 ext3 uboot.mxsboot-sdcard sdcard"
> -
>  MACHINE_FEATURES = "apm usbgadget usbhost vfat touchscreen"
> diff --git a/conf/machine/imx28evk.conf b/conf/machine/imx28evk.conf
> index 86123c3..5a55d72 100644
> --- a/conf/machine/imx28evk.conf
> +++ b/conf/machine/imx28evk.conf
> @@ -17,9 +17,6 @@ UBOOT_CONFIG[sd-auart-console] = "mx28evk_auart_console_config,sdcard"
>
>  KERNEL_DEVICETREE = "imx28-evk.dtb"
>
> -SDCARD_ROOTFS ?= "${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ext3"
> -IMAGE_FSTYPES ?= "tar.bz2 ext3 uboot.mxsboot-sdcard sdcard"
> -
>  SERIAL_CONSOLE = "115200 ttyAMA0"
>
>  MACHINE_FEATURES = "apm usbgadget usbhost vfat alsa touchscreen"
> diff --git a/conf/machine/include/mxs-base.inc b/conf/machine/include/mxs-base.inc
> index d576dd3..b32e926 100644
> --- a/conf/machine/include/mxs-base.inc
> +++ b/conf/machine/include/mxs-base.inc
> @@ -35,5 +35,8 @@ SERIAL_CONSOLE = "115200 ttyAMA0"
>
>  KERNEL_IMAGETYPE = "zImage"
>
> +SDCARD_ROOTFS ?= "${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ext3"
> +IMAGE_FSTYPES ?= "tar.bz2 ext3 uboot.mxsboot-sdcard sdcard"
> +
>  # Add the ability to specify _imx machines
>  MACHINEOVERRIDES =. "imx:"
> --
> 2.5.3
>
> --
> _______________________________________________
> meta-freescale mailing list
> meta-freescale at yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-freescale


More information about the meta-freescale mailing list