[meta-freescale] [PATCH v3 5/7] valgrind: add bbappend for multilib support and override memcpy/memset

[Luo Zhenhua]

> -----Original Message-----
> From: Otavio Salvador [mailto:otavio.salvador at ossystems.com.br]
> Sent: Tuesday, September 01, 2015 12:23 AM
> 
> On Fri, Aug 28, 2015 at 5:18 AM, Luo Zhenhua <zhenhua.luo at freescale.com>
> wrote:
> >> -----Original Message-----
> >> From: Otavio Salvador [mailto:otavio.salvador at ossystems.com.br]
> >> Sent: Thursday, August 27, 2015 9:46 PM
> >>
> >> On Mon, Aug 24, 2015 at 12:31 AM, Zhenhua Luo
> >> <zhenhua.luo at freescale.com>
> >> wrote:
> >> > +
> >> > +    if (!(echo "${MACHINE}"     | grep --quiet "\-64b") && # 32-bit
> >> > +        !(echo "${TARGET_ARCH}" | grep --quiet "64")) ||
> >> > +         (echo "${MACHINE}"     | grep --quiet "\-64b"  && # 64-bit
> >> > +          echo "${TARGET_ARCH}" | grep --quiet "64"); then
> >> > +        cd ${D}/${bindir}
> >> > +        ln -sf ${TARGET_ARCH}-valgrind valgrind
> >> > +    fi
> >> > +}
> >>
> >> I understand the need for this but I think a better way to do is:
> >>
> >>  - use program-prefix always
> >>  - use update-alternatives to maintain the link This can be done
> >> upstream.
> > [Luo Zhenhua-B19537] I tried to utilize update-alternatives bbclass, the
> following syntax is not supported by update-alternatives.
> >         ALTERNATIVE_${PN} = "valgrind-${TARGET_ARCH}"
> >         ALTERNATIVE_LINK_NAME[valgrind-${TARGET_ARCH}] = "valgrind"
> >
> >         ERROR: ParseError at ./poky/meta/recipes-
> devtools/valgrind/valgrind_3.10.0.bb:102: unparsed line:
> 'ALTERNATIVE_LINK_NAME[valgrind-${TARGET_ARCH}] = "valgrind"'
> 
> So please add the patch, set package-arch accordingly and let's work on this at
> upstream. 
[Luo Zhenhua-B19537] I think you mean submit patch to use current way and add PACKAGE_ARCH = "'${MACHIINE_ARCH}", is this right? 

> This is a valid use case for multilib and we ought to discuss this at oe-
> core to see how to address the issue in a clean way.
[Luo Zhenhua-B19537] I can initial an email to oe-core mailist to discuss the topic, 


Best Regards,

Zhenhua