[meta-freescale] [PATCH V2] imx-base.inc: Enable thumb2 and vfp capability

[Andreas Müller]

On Wed, May 27, 2015 at 9:49 PM, Khem Raj <raj.khem at gmail.com> wrote:
> MX6 SoCs have VFP unit and also support thumb2 ISA
> This patch makes the default machine tunes aware of thumb2 and VFP.
>
> The ISA for code generation still remains as it was before this patch,
> in addition it now offers different ISA options to OE distributions e.g
> thumb2,  mixed (Thumb2/ARM) or ARM (default)
>
> Discussions which resulted in this patch are here [1]
>
> [1] https://lists.yoctoproject.org/pipermail/meta-freescale/2015-May/013904.html
>
> Signed-off-by: Khem Raj <raj.khem at gmail.com>
> ---
>  conf/machine/include/imx-base.inc | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/conf/machine/include/imx-base.inc b/conf/machine/include/imx-base.inc
> index 5683041..d80ca46 100644
> --- a/conf/machine/include/imx-base.inc
> +++ b/conf/machine/include/imx-base.inc
> @@ -30,11 +30,13 @@ PREFERRED_VERSION_directfb_mx6 = "1.7.4"
>  # Ship kernel modules
>  MACHINE_EXTRA_RRECOMMENDS = "kernel-modules"
>
> -# Float-Point setting
> +# Defaults is to show thumb2, VFP and Neon
> +# capabilities
> +# Float-Point ABI setting
>  # handled by software
> -# DEFAULTTUNE_mx6 ?= "cortexa9-neon"
> +# DEFAULTTUNE_mx6 ?= "cortexa9t2-vfp-neon"
>  # handled by hardware
> -DEFAULTTUNE_mx6 ?= "cortexa9hf-neon"
> +DEFAULTTUNE_mx6 ?= "cortexa9t2hf-vfp-neon"
>
>  # Sub-architecture support
>  MACHINE_SOCARCH_SUFFIX ?= ""
> --
> 2.1.4
>
> --
Instead discussing commit message: this patch breaks parsing with

ERROR:  OE-core's config sanity checker detected a potential misconfiguration.
    Either fix the cause of this error or at your own risk disable the
checker (see sanity.conf).
    Following is the list of potential problems / advisories:

    Error, the PACKAGE_ARCHS variable does not contain TUNE_PKGARCH
(${ARMPKGARCH_tune-cortexa9t2hf-vfp-neon}).Toolchain tunings invalid:
Tuning 'cortexa9t2hf-vfp-neon' has no defined features, and cannot be used.

A look into oe-core meta/conf/machine/include/tune-cortexa9.inc / line

PACKAGE_EXTRA_ARCHS_tune-cortexa9thf-neon =
"${PACKAGE_EXTRA_ARCHS_tune-armv7athf-neon} cortexa9hf-vfp
cortexa9hf-vfp-neon cortexa9t2hf-vfp cortexa9t2hf-vfp-neon"

makes me say "my patch is nicer" :)

Andreas