[meta-freescale] [meta-fsl-arm][PATCH] imx-base.inc: Advertize thumb2 and vfp capability

[Daiane Angolini]

On Wed, May 27, 2015 at 3:17 PM, Otavio Salvador
<otavio at ossystems.com.br> wrote:
> On Wed, May 27, 2015 at 12:33 PM, Khem Raj <raj.khem at gmail.com> wrote:
>> These SoCs are capable of thmub2 ISA as well as VFP
>> unit is available on them. This patch makes the default
>> tunes aware of that. The final ISA still remains as it is currently but
>> it offers a choice to distros to choose an alternative thumb2 or a mix
>> if they want to.
>>
>> Signed-off-by: Khem Raj <raj.khem at gmail.com>
>
> Your patch seems nicer; it would be good though if you could add the
> discussion link included at:
>
> http://patchwork.openembedded.org/patch/94025/

And please, improve your commit log a little bit. I think it's confusing.

"These SoCs are capable of thmub2 ISA as well as VFP
unit is available on them. This patch makes the default
tunes aware of that. The final ISA still remains as it is currently but
it offers a choice to distros to choose an alternative thumb2 or a mix
if they want to."

Instead of "these socs" please say "The mx6 SoCs"

typo thmub2 -> thumb2

soc are capable of thumb2 and VFP unit is available?

"The final ISA still remains as it is currently"
 What does it means? The default for ISA is the same?

And please, avoid choice and choose in the same sentence. And I'm not
sure what you mean by "thumb2 or a mix, if they want to" (who is they?
distros doesn't make choices )

Maybe something like:

"
mx6 SoC can be used with both thumb2 ISA or VFP enabled.

Change the default tunes in order to enable both always.

In addition, it offers more options to external distros.
"

At least it was what I understood from your commit log. This way you
can double check if my understanding is what you meant.


Daiane


>
> --
> Otavio Salvador                             O.S. Systems
> http://www.ossystems.com.br        http://code.ossystems.com.br
> Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
> --
> _______________________________________________
> meta-freescale mailing list
> meta-freescale at yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-freescale