[meta-freescale] [meta-fsl-arm-extra][PATCH 4/4] cubox-i: Use += operator for MACHINE_FIRMWARE setting

[Daiane Angolini]

On Mon, May 11, 2015 at 10:21 AM, Otavio Salvador
<otavio at ossystems.com.br> wrote:
> Change-Id: I8b4d6eb94564f0e92abb6d9630fc3cf765b8fa8c
> Signed-off-by: Otavio Salvador <otavio at ossystems.com.br>

I reviewed all the patchset and the other patches are OK to me.

For this one, I think you can elaborate the commit log a little bit.

In fact, I would change commit subject to something like:

"cubox-i: Fix MACHINE_FIRMWARE operator"

And commit log:

"Use += operator for MACHINE_FIRMWARE because ...."

and include the reason.


Daiane
> ---
>  conf/machine/cubox-i.conf | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/conf/machine/cubox-i.conf b/conf/machine/cubox-i.conf
> index 9fb2a5f..4ea627f 100644
> --- a/conf/machine/cubox-i.conf
> +++ b/conf/machine/cubox-i.conf
> @@ -27,6 +27,6 @@ KERNEL_IMAGETYPE = "zImage"
>  KERNEL_DEVICETREE = "imx6dl-cubox-i.dtb imx6q-cubox-i.dtb imx6dl-hummingboard.dtb imx6q-hummingboard.dtb"
>
>  MACHINE_FEATURES += "pci wifi bluetooth alsa bluetooth irda serial usbhost wifi"
> -MACHINE_FIRMWARE_append_mx6 = " linux-firmware-ath6k"
> +MACHINE_FIRMWARE += "linux-firmware-ath6k"
>
>  SERIAL_CONSOLE = "115200 ttymxc0"
> --
> 2.1.4
>
> --
> _______________________________________________
> meta-freescale mailing list
> meta-freescale at yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-freescale