[meta-freescale] [meta-fsl-arm][PATCH v3] fsl-dynamic-packagearch: on thumb builds, add MACHINE_SOCARCH arm feed

[Max Krummenacher]

Hi

2015-03-27 23:33 GMT+01:00 Otavio Salvador <otavio at ossystems.com.br>:
> Hello Max,
>
> (I have added some more people to the Cc list as I think this is a
> generic problem)
>
> On Fri, Mar 27, 2015 at 10:12 AM, Max Krummenacher <max.oss.09 at gmail.com> wrote:
>> This ensures that all MACHINE_SOCARCH feeds are part of PACKAGE_EXTRA_ARCHS.
>>
>> oe-core now puts packages into an arm feed dir when a recipe forces the
>> ARM instruction set on a build configured to default to thumb.
>> http://cgit.openembedded.org/openembedded-core/commit/?id=3e760031f91fb87c3e2f62b77a117eb41164f259
>>
>> This is true also for packages in MACHINE_SOCARCH, i.e. we get in deploy/ipk for
>> an angstrom based build:
>> armv7ahf-vfp-neon-mx6qdl  armv7at2hf-vfp-neon-mx6qdl
>> so we must put both into PACKAGE_EXTRA_ARCHS.
>>
>> In theorie, but less likely, the opposite is also true. If a recipe explicitely
>> sets thumb in a build configured for arm the resulting packages end up in a
>> thumb feed.
>>
>> Signed-off-by: Max Krummenacher <max.oss.09 at gmail.com>
>
> For reference of the source changes, the patch is online[1].
>
> 1. http://patchwork.openembedded.org/patch/90989/
>
> I think when thumb is used, the normal ARM should be added but the
> inverse shouldn't be truth as I might want to not use thumb at all.
Note that this use case is more academic. I have not found a single
recipe which forces thumb mode in the layers I have on disk. Plus I
did not test if and how a build would fail when adding such a recipe
to an image.

>
> In any case, I think this should be handled in the generic code which
> adds the PACKAGE_EXTRA_ARCHES and not in our class.
>
> Please people, I need your view on this...
>
> --
> Otavio Salvador                             O.S. Systems
> http://www.ossystems.com.br        http://code.ossystems.com.br
> Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Regards
Max