[meta-freescale] [meta-fsl-arm][PATCH 2/2] machines: Add IMAGE_BOOT_FILES

[Otavio Salvador]

On Mon, Mar 2, 2015 at 10:04 AM, Alexandre Belloni
<alexandre.belloni at free-electrons.com> wrote:
> On 02/03/2015 at 09:35:36 -0300, Otavio Salvador wrote :
>> On Mon, Mar 2, 2015 at 8:45 AM, Alexandre Belloni
>> <alexandre.belloni at free-electrons.com> wrote:
>> > Define IMAGE_BOOT_FILES in the machine configuration to be able to
>> > create sdcard images using wic.
>> >
>> > Signed-off-by: Alexandre Belloni <alexandre.belloni at free-electrons.com>
>>
>> Thanks for looking at this; wic is indeed a very handy addition :-)
>>
>> > diff --git a/conf/machine/imx51evk.conf b/conf/machine/imx51evk.conf
>> > index 9d7d06ca41fc..89bcacb932fb 100644
>> > --- a/conf/machine/imx51evk.conf
>> > +++ b/conf/machine/imx51evk.conf
>> > @@ -13,5 +13,6 @@ SOC_FAMILY = "mx5:mx51"
>> >  PERF_FEATURES_ENABLE = ""
>> >
>> >  KERNEL_DEVICETREE = "imx51-babbage.dtb"
>> > +IMAGE_BOOT_FILES = "zImage zImage-imx51-babbage.dtb;imx51-babbage.dtb"
>> >
>> >  UBOOT_MACHINE = "mx51evk_config"
>>
>> To be honest, I don't like the idea of maintaining the list of
>> duplicated device tree files.
>>
>> I am wondering if we can cook a generic solution whick uses
>> KERNEL_DEVICETREE as input and generates the list of artifacts it
>> needs to install. Leaving them disconnected is very error prone.
>>
>
> I agree but that is the current mechanism. Actually, I think we should
> even have a better mechanism were it would be possible to select which
> files are going to which partition. I didn't implement it yet.
>
> There is one issue with generating the IMAGE_BOOT_FILES from
> KERNEL_DEVICETREE. You can put non existing dtb filenames in
> KERNEL_DEVICETREE and they will be ignored but not in IMAGE_BOOT_FILES.
> That is the case for imx6qsabresd.conf.

No; they will fail to build in the kernel as this is passed on kernel
make command.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750