[meta-freescale] [meta-fsl-arm][PATCH] Added support for Embedsky E9 mini PC board
Daiane Angolini
daiane.list at gmail.com
Mon Jun 15 04:25:02 PDT 2015
https://github.com/Freescale/meta-fsl-arm-extra/commit/5fadb641dffe91ec9dedafcb1e27add3e45255dc
On Sun, Jun 14, 2015 at 3:47 PM, Gyorgy Kovesdi <kgy at teledigit.eu> wrote:
> Hi,
>
Please, add a proper commit log, not starting with "Hi" =P
If you need to communicate with mailing list, use a cover-letter ;-)
For commit subject, please use "Add suport for xxx board"
The last board I included on meta-fsl-arm-extra has a huge commit log,
you can take a look on that in order to have an idea which information
to add
https://github.com/Freescale/meta-fsl-arm-extra/commit/5fadb641dffe91ec9dedafcb1e27add3e45255dc
And please, keep the URL pointing to embedsky site
> The bootloader (barebox_2015.05.0) and the kernel (4.1.0) runs on my
> Embedsky E9 min PC
> http://en.embedsky.com/product_info.php?cateid=169&id=169
>
> Currently only the USB, the Ethernet, and the SATA have been tested.
>
> Many thanks to Панов Андрей <rockford at yandex.ru>
>
> Signed-off-by: György Kövesdi <kgy at teledigit.eu>
> ---
> conf/machine/embedsky-e9.conf | 31 +
this file should go to meta-fsl-arm-extra
> conf/machine/include/imx-base.inc | 2 +-
> recipes-bsp/barebox/barebox.inc | 63 +-
> recipes-bsp/barebox/barebox/defconfig/embedsky-e9.config | 649 +++++++++
> recipes-bsp/barebox/barebox_2015.05.0.bb | 11 +
I would prefer if the barebox_2015.05 could replace the old version. I
would place barebox files on meta-fsl-arm, and include a bbappend on
meta-fsl-arm-extra for embedsky specific files on meta-fsl-arm-extra
> .../linux/linux-e9/0001-kgy-embedsky-e9-1-dts-added.patch| 28 +
> recipes-kernel/linux/linux-e9/defconfig | 3905 ++++++++
> recipes-kernel/linux/linux-e9_4.bb | 33 +
this kernel goes to meta-fsl-arm-extra
> 8 files changed, 4693 insertions(+), 29 deletions(-)
> create mode 100644 conf/machine/embedsky-e9.conf
> create mode 100644 ...bsp/barebox/barebox/defconfig/embedsky-e9.config
> create mode 100644 recipes-bsp/barebox/barebox_2015.05.0.bb
> create mode 100644 .../linux-e9/0001-kgy-embedsky-e9-1-dts-added.patch
> create mode 100644 recipes-kernel/linux/linux-e9/defconfig
> create mode 100644 recipes-kernel/linux/linux-e9_4.bb
>
> diff --git a/conf/machine/embedsky-e9.conf
> b/conf/machine/embedsky-e9.conf new file mode 100644
> index 0000000..921d57e
> --- /dev/null
> +++ b/conf/machine/embedsky-e9.conf
> @@ -0,0 +1,31 @@
> +#@TYPE: Machine
> +#@NAME: Freescale i.MX6Q Embedsky E9 Device
> +#@SOC: i.MX6Q
> +#@DESCRIPTION: Machine configuration for Freescale i.MX6Q Embedsky E9
> Device +#@MAINTAINER: Gyorgy Kovesdi <kgy at teledigit.eu>
> +
> +require conf/machine/include/imx-base.inc
> +require conf/machine/include/tune-cortexa9.inc
> +
> +SOC_FAMILY = "mx6:mx6q"
> +PREFERRED_PROVIDER_virtual/kernel = "linux-e9"
> +IMAGE_BOOTLOADER = "barebox"
> +BAREBOX_BINARY = "images/barebox-freescale-imx6q-embedsky-e9.img"
> +BAREBOX_SYMLINK ?= "barebox-embedsky-e9.img"
> +BAREBOX_CONFIG = "embedsky-e9"
> +
> +KERNEL_IMAGETYPE = "zImage"
> +KERNEL_DEVICETREE = "imx6q-embedsky-e9-1.dts"
> +
> +SERIAL_CONSOLE = "115200 ttymxc0"
> +
> +MACHINE_FIRMWARE_append_mx6 = " linux-firmware-ath6k"
> +
> +MACHINE_FEATURES += " pci bluetooth"
> +
> +PACKAGE_CLASSES = "package_ipk"
> +
> +# Some erroneous packages are disabled temporarily:
> +MACHINE_GSTREAMER_PLUGIN = ""
> +# MACHINE_EXTRA_RRECOMMENDS_append_mx6 = ""
Please, don't include commented source code.
Take a look on this commit in order to see an example of using linux-fslc only
https://github.com/Freescale/meta-fsl-arm-extra/commit/ca0a8bb09e1ee7fa96235324c583eefbfbe872e9
> +
> diff --git a/conf/machine/include/imx-base.inc
> b/conf/machine/include/imx-base.inc index 9ac5e8a..ffd4c2e 100644
> --- a/conf/machine/include/imx-base.inc
> +++ b/conf/machine/include/imx-base.inc
> @@ -70,7 +70,7 @@ MACHINE_EXTRA_RRECOMMENDS += "${MACHINE_FIRMWARE}"
>
> # Extra audio support
> # FIXME: Add support for ALL SoC families
> -MACHINE_EXTRA_RRECOMMENDS_append_mx6 = " fsl-alsa-plugins"
> +# MACHINE_EXTRA_RRECOMMENDS_append_mx6 ?= " fsl-alsa-plugins"
Please, drop this line, it break all mx6 board. and you don't actually need it.
>
> # Extra udev rules
> MACHINE_EXTRA_RRECOMMENDS += "udev-extraconf"
> diff --git a/recipes-bsp/barebox/barebox.inc
> b/recipes-bsp/barebox/barebox.inc index 0d5c127..d55046f 100644
> --- a/recipes-bsp/barebox/barebox.inc
> +++ b/recipes-bsp/barebox/barebox.inc
I cannot comment on barebox specific changes, I prefer if someone else
could comment.
(...)
> diff --git a/recipes-bsp/imx-lib/imx-lib_3.10.17-1.0.0.bb
> b/recipes-bsp/imx-lib/imx-lib_3.10.17-1.0.0.bb deleted file mode 100644
Please, don't break other machines.
> index 212ec3f..0000000
> --- a/recipes-bsp/imx-lib/imx-lib_3.10.17-1.0.0.bb
> +++ /dev/null
> @@ -1,11 +0,0 @@
> -# Copyright (C) 2013, 2014 Freescale Semiconductor
> -
> -include imx-lib.inc
> -
> -PE = "1"
> -
> -SRC_URI += "file://obey-variables.patch"
> -SRC_URI[md5sum] = "8e3346d5f33b5aa5f915a0dd8aa99cc9"
> -SRC_URI[sha256sum] =
> "f42605971977e5fe1ed9e7ce17ea3f97586a23fbc60fa0f679940d379c72303e" -
> -COMPATIBLE_MACHINE = "(mx6)"
> diff --git
> a/recipes-kernel/linux/linux-e9/0001-kgy-embedsky-e9-1-dts-added.patch
> b/recipes-kernel/linux/linux-e9/0001-kgy-embedsky-e9-1-dts-added.patch
> new file mode 100644 index 0000000..f19b132 --- /dev/null
> +++
> b/recipes-kernel/linux/linux-e9/0001-kgy-embedsky-e9-1-dts-added.patch
> @@ -0,0 +1,28 @@ +diff --git
> a/arch/arm/boot/dts/imx6q-embedsky-e9-1.dts
> b/arch/arm/boot/dts/imx6q-embedsky-e9-1.dts +new file mode 100644
> +index 0000000..6a3527e +--- /dev/null
> ++++ b/arch/arm/boot/dts/imx6q-embedsky-e9-1.dts
> +@@ -0,0 +1,22 @@
> ++/*
> ++ * Copyright 2012 Freescale Semiconductor, Inc.
> ++ * Copyright 2011 Linaro Ltd.
Where is /imx6q-embedsky-e9-1.dts file from? Why such copyright?
> ++ *
> ++ * The code contained herein is licensed under the GNU General Public
> ++ * License. You may obtain a copy of the GNU General Public License
> ++ * Version 2 or later at the following locations:
> ++ *
> ++ * http://www.opensource.org/licenses/gpl-license.html
> ++ * http://www.gnu.org/copyleft/gpl.html
> ++ */
> ++
> ++/dts-v1/;
> ++
> ++#include "imx6q.dtsi"
> ++#include "imx6q-embedsky-e9-1.dtsi"
> ++
> ++/ {
> ++ chosen {
> ++ linux,stdout-path = &uart4;
> ++ };
> ++};
> diff --git a/recipes-kernel/linux/linux-e9/defconfig
> b/recipes-kernel/linux/linux-e9/defconfig new file mode 100644
> index 0000000..a8e1b8b
> --- /dev/null
> +++ b/recipes-kernel/linux/linux-e9/defconfig
Have you used savedefconfig to generate defconfig file?
> @@ -0,0 +1,3905 @@
> +#
> +# Automatically generated file; DO NOT EDIT.
> +# Linux/arm 4.1.0-rc6 Kernel Configuration
And here my gmail got crazy and could not include the other lines of your patch.
One more thing, please, add a SUMMARY and a DESCRIPTION on your new
kernel recipe, and a pretty LOCALVERSION
(these 2 information are used in FSL Community BSP Release Notes, so
it's better if they are pretty.)
Only add a new kernel provider if you were not using kernel mainline.
If it is only few patches submit then to kernel.org and then a pull
request to get it included in https://github.com/Freescale/linux-fslc
Please, split the commit into other commits (something like that):
* one for including barebox main recipe
* one for including your kernel provider, if needed
* one for including your board specific bits for barebox
* one for your machine
Daiane
More information about the meta-freescale
mailing list