[meta-freescale] [meta-fsl-arm][PATCH v3 0/7] 3.14.38-6QP_Beta release
Zhu Carol
B54851 at freescale.com
Wed Jul 29 22:34:34 PDT 2015
Hi Carlos,
After dissuccsion, we decide to change them to "Submitted", and the bugzilla link for each patch are below.
- "gstreamer1.0-plugins-base: Add gstplaysink related patch" comments out the line which sets the async flag of the subtitle sink to FALSE.
https://bugzilla.gnome.org/show_bug.cgi?id=747499
- "Sending EOS event instead of GAP event as GAP event has error if A/V have the different duration."
https://bugzilla.gnome.org/show_bug.cgi?id=727074
- "Make memory copy when video buffer's memory is read only" (this one sounds like a serious GStreamer bug if true!) etc.
https://bugzilla.gnome.org/show_bug.cgi?id=747495
B.R.
Yuqing Zhu
-----Original Message-----
From: Carlos Rafael Giani [mailto:dv at pseudoterminal.org]
Sent: Wednesday, July 29, 2015 6:55 PM
To: Zhu Yuqing-B54851; meta-freescale at yoctoproject.org
Subject: Re: [meta-freescale] [meta-fsl-arm][PATCH v3 0/7] 3.14.38-6QP_Beta release
Hi Zhu,
patches which are submitted but still in discussion need to be marked as "Pending" or "Submitted". See http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines . This also means that most of these patches should then actually be sent to oe-core, in my opinion. Also, in case the patch is related to a discussion with the developers, please also add a link to bugzilla, or any kind of reference to the discussion you might have.
The problem with the "i.MX specific" label is that this should be used only if for example you are using a workaround for a bug that only appears on i.MX devices. Otherwise, this label is misleading, since the i.MX hardware is not really a significant factor for these patches.
Carlos
Am 2015-07-29 um 12:37 schrieb Zhu Carol:
> Hi Carlos,
> Please check comments below.
>
> B.R.
> Yuqing Zhu
>
> -----Original Message-----
> From: Carlos Rafael Giani [mailto:dv at pseudoterminal.org]
> Sent: Tuesday, July 28, 2015 6:28 PM
> To: Zhu Yuqing-B54851; meta-freescale at yoctoproject.org
> Subject: Re: [meta-freescale] [meta-fsl-arm][PATCH v3 0/7]
> 3.14.38-6QP_Beta release
>
> Why are some of these i.MX specific? For example:
> - "gstreamer1.0-plugins-base: Add gstplaysink related patch" comments out the line which sets the async flag of the subtitle sink to FALSE.
> [Zhu Yuqing] the patch is submitted, but still in discussion with community, so we make it as i.MX specific.
>
> - "Sending EOS event instead of GAP event as GAP event has error if A/V have the different duration."
> [Zhu Yuqing] This patch is just a workaround in 1.4.5, 1.6 will have a good solution for this, but can't be applied to 1.4.5, so we treat this patch as i.MX specific.
>
> - "Make memory copy when video buffer's memory is read only" (this one sounds like a serious GStreamer bug if true!) etc.
> [Zhu Yuqing] the patch is submitted, but still in discussion with community, so we make it as i.MX specific.
>
> Where is the specific connection to the i.MX hardware?
>
> Also, removing the default deinterlace and native-video flags sounds problematic to me. If there is deinterlaced video, playbin will insert the software deinterlacer, which is slow on i.MX.
> [Zhu Yuqing] we removed GST_PLAY_FLAG_DEINTERLACE, but not enable native video, as subtitleoverlay plugin can't work when native video enabled. This won't hurt performance, as videoconvert can work in passthrough mode.
>
> Are these patches perhaps actually gst1.0-fsl-plugins specific? To get this stuff to work with the aiur demuxer etc.?
> [Zhu Yuqing] These patches are not related with gst1.0-fsl-plugins specific, all are gstreamer issues.
>
>
> Am 2015-07-28 um 19:54 schrieb Yuqing Zhu:
>> Fix issue about gstreamer1.0-plugins-base
>>
>> -gstplaybin: Remove native video flag and deinterlace flag.
>>
>> -basetextoverlay: Make memory copy when video buffer's memory is ready only.
>>
>> -gstplaysink: Don't set async of custom text-sink to false.
>>
>> -ssaparse: Enhance SSA text lines parsing.
>>
>> -subparse: Set need_segment after sink pad receive GST_EVENT_SEGMENT.
>>
>> -gststreamsynchronizer: Sending EOS event instead of GAP event as GAP event has issue when A/V have
>> different duration.
>> Stop sending second track EOS event if sending the first track EOS return fail.
>>
>> -encodebin: Need more buffers in output queue for better performance.
>>
>>
>> Yuqing Zhu (7):
>> gstreamer1.0-plugins-base: Add gstplaybin related patch
>> gstreamer1.0-plugins-base: Add gststreamsynchronizer related patch
>> gstreamer1.0-plugins-base: Add basetextoverlay related patch
>> gstreamer1.0-plugins-base: Add gstplaysink related patch
>> gstreamer1.0-plugins-base: Add ssaparse related patch
>> gstreamer1.0-plugins-base: Add subparse related patch
>> gstreamer1.0-plugins-base: Add encodebin related patch
>>
>> ...rlay-make-memory-copy-when-video-buffer-s.patch | 129 ++++++++++++
>> ...-don-t-set-async-of-custom-text-sink-to-f.patch | 31 +++
>> ...3-ssaparse-enhance-SSA-text-lines-parsing.patch | 225 +++++++++++++++++++++
>> ...t-need_segment-after-sink-pad-received-GS.patch | 69 +++++++
>> .../do-not-change-eos-event-to-gap-event2.patch | 51 +++++
>> .../do-not-change-eos-event-to-gap-event3.patch | 33 +++
>> ...eed-more-buffers-in-output-queue-for-bett.patch | 34 ++++
>> ...ch => gstplaybin-remove-flag-deinterlace.patch} | 10 +-
>> .../gstreamer/gstreamer1.0-plugins-base_%.bbappend | 23 ++-
>> 9 files changed, 596 insertions(+), 9 deletions(-)
>> create mode 100644 recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/0001-basetextoverlay-make-memory-copy-when-video-buffer-s.patch
>> create mode 100644 recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/0002-gstplaysink-don-t-set-async-of-custom-text-sink-to-f.patch
>> create mode 100644 recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/0003-ssaparse-enhance-SSA-text-lines-parsing.patch
>> create mode 100644 recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/0004-subparse-set-need_segment-after-sink-pad-received-GS.patch
>> create mode 100755 recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/do-not-change-eos-event-to-gap-event2.patch
>> create mode 100755 recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/do-not-change-eos-event-to-gap-event3.patch
>> create mode 100644 recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/encodebin-Need-more-buffers-in-output-queue-for-bett.patch
>> rename
>> recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/{gstplaybin-en
>> able-native-video.patch => gstplaybin-remove-flag-deinterlace.patch}
>> (79%)
>>
More information about the meta-freescale
mailing list