[meta-freescale] [meta-fsl-arm][PATCH v2 1/7] gstreamer1.0-plugins-base: Add gstplaybin related patch

[Zhu Carol]

Hello Otavio,
    gstreamer1.0-plugins-base doesn't include gst pango lib by default. We need to enable pango lib compiling in ./poky/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base.inc, which is used to generate the texture. And it is i.MX 6/7 SOC specific
    

-----Original Message-----
From: Otavio Salvador [mailto:otavio.salvador at ossystems.com.br] 
Sent: Tuesday, July 28, 2015 1:01 AM
To: Zhu Yuqing-B54851
Cc: meta-freescale at yoctoproject.org
Subject: Re: [meta-freescale] [meta-fsl-arm][PATCH v2 1/7] gstreamer1.0-plugins-base: Add gstplaybin related patch

Hello,

On Mon, Jul 27, 2015 at 7:46 AM, Yuqing Zhu <b54851 at freescale.com> wrote:
> -Remove default deinterlace flag in playbin for i.MX SoCs
>
> -Remove native video flag in playbin for i.MX SoCs because it will 
> cause subtitle error
>
> Signed-off-by: Yuqing Zhu <b54851 at freescale.com>


> ---
>  ...ative-video.patch => gstplaybin-remove-flag-deinterlace.patch} | 8 
> ++++----  
> recipes-multimedia/gstreamer/gstreamer1.0-plugins-base_%.bbappend | 8 
> ++++----
>  2 files changed, 8 insertions(+), 8 deletions(-)  rename 
> recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/{gstplaybin-ena
> ble-native-video.patch => gstplaybin-remove-flag-deinterlace.patch} 
> (84%)
>
> diff --git 
> a/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/gstplaybin-en
> able-native-video.patch 
> b/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/gstplaybin-re
> move-flag-deinterlace.patch
> similarity index 84%
> rename from 
> recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/gstplaybin-enab
> le-native-video.patch rename to 
> recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/gstplaybin-remo
> ve-flag-deinterlace.patch
> index 15322bd..ab6d4b1 100644
> --- 
> a/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/gstplaybin-en
> able-native-video.patch
> +++ b/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/gstplaybi
> +++ n-remove-flag-deinterlace.patch
> @@ -1,9 +1,9 @@
>  From 9cfb86cd100904f0ef2626f348695bd2d3416c6a Mon Sep 17 00:00:00 
> 2001
>  From: Jian Li <jian.li at freescale.com>
>  Date: Mon, 23 Jun 2014 14:14:07 +0800
> -Subject: [PATCH] gstplaybin enable native video
> +Subject: [PATCH] gstplaybin remove default deinterlace flag
>
> -- use native video patch in playbin for i.MX SoCs
> +- remove default deinterlace flag in playbin for i.MX SoCs
>
>  Upstream Status: Inappropriate [platform specific]
>
> @@ -22,10 +22,10 @@ index fc02ca3..c342438 100644
>   #define DEFAULT_FLAGS             GST_PLAY_FLAG_AUDIO | GST_PLAY_FLAG_VIDEO | GST_PLAY_FLAG_TEXT | \
>  -                                  GST_PLAY_FLAG_SOFT_VOLUME | GST_PLAY_FLAG_DEINTERLACE | \
>  -                                  GST_PLAY_FLAG_SOFT_COLORBALANCE
> -+                                  GST_PLAY_FLAG_SOFT_VOLUME | 
> -+ GST_PLAY_FLAG_NATIVE_VIDEO
> ++                                  GST_PLAY_FLAG_SOFT_VOLUME
>   #define DEFAULT_N_VIDEO           0
>   #define DEFAULT_CURRENT_VIDEO     -1
>   #define DEFAULT_N_AUDIO           0
> ---
> +--
>  1.7.9.5
>
> diff --git 
> a/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base_%.bbappend 
> b/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base_%.bbappend
> index 5b939d4..aa34165 100644
> --- 
> a/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base_%.bbappend
> +++ b/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base_%.bbappen
> +++ d
> @@ -1,9 +1,9 @@
> -
>  FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
>
> -SRC_URI_append_mxs = " file://gstplaybin-enable-native-video.patch"
> -SRC_URI_append_mx5 = " file://gstplaybin-enable-native-video.patch"
> -SRC_URI_append_mx6 = " file://gstplaybin-enable-native-video.patch"
> +SRC_URI_append = " file://gstplaybin-remove-flag-deinterlace.patch"

This need to be made imx specific. This is being appended in all SoCs which imply a machine contamination so please fix this.

> +# Enable pango lib
> +PACKAGECONFIG_append = " pango "

This is a DISTRO option and not acceptable here. Does i.MX depends on Pango support? I doubt it.

>  PACKAGE_ARCH_mxs = "${MACHINE_SOCARCH}"
>  PACKAGE_ARCH_mx5 = "${MACHINE_SOCARCH}"
> --
> 1.9.1
>
> --
> _______________________________________________
> meta-freescale mailing list
> meta-freescale at yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-freescale



-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750