[meta-freescale] [meta-fsl-demos][PATCH v2 4/9] packagegroup-fsl-tools-testapps: Add tools and apps used in testing

[Daiane Angolini]

On Thu, Jul 16, 2015 at 4:23 PM, Lauren Post <lauren.post at freescale.com> wrote:
> Add additional tools used in i.MX testing including the codec
> unit tests and the tools used by testing.
>
> Note that a few tools used in i.MX not included because they require
> additional layers configured.  These tools are ntpdate and vlan
> which requires meta-networking under meta-openembbeded.
>
> Signed-off-by: Lauren Post <lauren.post at freescale.com>
> ---
>  .../packagegroup-fsl-tools-testapps.bb             |   28 ++++++++++++++++++++
>  1 file changed, 28 insertions(+)
>
> diff --git a/recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb b/recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb
> index 98e6e5c..9f84696 100644
> --- a/recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb
> +++ b/recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb
> @@ -23,6 +23,15 @@ SOC_TOOLS_TEST_mx6 = " \
>      imx-gpu-viv-demos \
>  "
>
> +PACKAGES += " \
> +    ${PN}-fslcodec-testapps \
> +"
> +RDEPENDS_${PN}-fslcodec-testapps += " \
> +    libfslcodec-test-bin \
> +    libfslcodec-test-source \

libfslcodec-test-souce should be condicioned with native build tools.
As I remember, the binary generated by -test-source is different from
the bin installed in -test-bin. It means the source code with no gcc
is useless .

In addition, if this is going to be used by default. I would review
the installation target:

"
FILES_${PN}-test-bin += "${datadir}/imx-mm/*/examples/*/bin"

FILES_${PN}-test-source += "${datadir}/imx-mm/*"
"




> +"
> +ALLOW_EMPTY_${PN}-fslcodec-testapps = "1"
> +
>  RDEPENDS_${PN} = " \
>      alsa-utils \
>      alsa-tools \
> @@ -37,6 +46,14 @@ RDEPENDS_${PN} = " \
>      python-subprocess \
>      python-datetime \
>      python-json \
> +    procps \
> +    linuxptp \
> +    iw \
> +    can-utils \
> +    cpufrequtils \
> +    nano \
> +    minicom \

nano and minicom?

Can you, please, explain why you want to include a text editor and a
serial comm app installed? It looks a little bit over to me.

The other I would not be against their inclusion, if they are still
building and no one has a good argument to avoid them.

But I would like to have a good explanation on why they are being
included, and "apps used by freescale test" does not look like a good
argument, as I expect Freescale has its own meta-layer only to control
the internal tests.


> +    coreutils \
>      ${@base_contains('DISTRO_FEATURES', 'x11', 'v4l-utils', '', d)} \
>      ethtool \
>      mtd-utils \
> @@ -46,8 +63,19 @@ RDEPENDS_${PN} = " \
>                                      'weston weston-examples \
>                                       gtk+3-demo clutter-1.0-examples', '', d), d)} \
>      ${SOC_TOOLS_TEST} \
> +    ${SOC_TOOLS_TESTAPPS} \
>  "
>
>  # FIXME: i.MX6SL cannot use mesa for Graphics and it lacks GL support,
>  #        so for now we skip it.
>  RDEPENDS_${PN}_remove_mx6sl = "clutter-1.0-examples"
> +
> +IMX_TESTAPPS = "  \
> +    imx-kobs \
> +    cryptodev-module \
> +    cryptodev-tests \
> +    ${PN}-fslcodec-testapps \
> +"

They do not look like TESTAPPS to me, at least not completely. Could
you, please, rename the variable to really represent what they are
used for?

And it would be good to have a better explanation on commit log why
this is important to be included

Daiane
> +
> +SOC_TOOLS_TESTAPPS_mx6 += "${IMX_TESTAPPS}"
> +SOC_TOOLS_TESTAPPS_mx7 += "${IMX_TESTAPPS}"
> --
> 1.7.9.5
>
> --
> _______________________________________________
> meta-freescale mailing list
> meta-freescale at yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-freescale