[meta-freescale] [meta-fsl-demos][PATCH v2 1/9] packagegroup-fsl-gstreamer1.0: Create FSL Gstreamer package group

[Daiane Angolini]

On Thu, Jul 16, 2015 at 4:23 PM, Lauren Post <lauren.post at freescale.com> wrote:
> Create package group for Freescale Gstreamer 1.0 plugins.
>
> Signed-off-by: Lauren Post <lauren.post at freescale.com>
> ---
>  .../packagegroups/packagegroup-fsl-gstreamer1.0.bb |   19 +++++++++++++++++++

What is the need/purpose of this packagegroup?

Please, take a look at:
https://github.com/Freescale/meta-fsl-demos/blob/master/recipes-multimedia/packagegroups/packagegroup-fslc-gstreamer1.0.bb




>  1 file changed, 19 insertions(+)
>  create mode 100644 recipes-multimedia/packagegroups/packagegroup-fsl-gstreamer1.0.bb
>
> diff --git a/recipes-multimedia/packagegroups/packagegroup-fsl-gstreamer1.0.bb b/recipes-multimedia/packagegroups/packagegroup-fsl-gstreamer1.0.bb
> new file mode 100644
> index 0000000..74f5140
> --- /dev/null
> +++ b/recipes-multimedia/packagegroups/packagegroup-fsl-gstreamer1.0.bb
> @@ -0,0 +1,19 @@
> +# Copyright (C) 2012-2015 Freescale Semiconductor
> +# Released under the MIT license (see COPYING.MIT for the terms)
> +
> +DESCRIPTION = "Freescale package group - gstreamer"

A good way to try to enhance the description of a package is to answer
the common questions: what, where, why, how.

What is the package, why is it needed, how it can be included/used,
where is it located.

It's been very common to have a useless description:
Chair description: it's a chair

Instead use:
Chair description: an object commonly used for humans to sit. it
usually has a flat surface to sit on top of it and a perpendicular
flat surface used to rest the back. Another possible use is to stand
on the sitting surface in order to reach high places in the kitchen
where ramequins are stored.

It's not only an advice for this patch, but every single DESCRIPTION I
review in this mailing list tends to be a useless description.


> +LICENSE = "MIT"
> +
> +PACKAGE_ARCH = "${MACHINE_ARCH}"
> +
> +inherit packagegroup
> +
> +RDEPENDS_${PN} += " \
> +    gstreamer1.0-plugins-good-meta \
> +    gstreamer1.0-plugins-base-meta \
> +    gstreamer1.0-rtsp-server \
> +    gstreamer1.0-plugins-bad-meta \


---
> +    ${MACHINE_GSTREAMER_1_0_PLUGIN} \
> +    ${@base_contains("MACHINE_GSTREAMER_1_0_PLUGIN", "gst1.0-fsl-plugin", "gst1.0-fsl-plugin-gplay", "", d)} \
> +    ${@base_contains("MACHINE_GSTREAMER_1_0_PLUGIN", "gst1.0-fsl-plugin", "gst1.0-fsl-plugin-grecorder", "", d)}
----
Maybe, this is the purpose of this packagegroup. In this case, I would
prefer a different name, change the focus to only deal with Freescale
plugins addition, and have this packagegroup to be included in the
gstreamer-full packagegroup.

I also would like to have the possibility of having both community and
freescale plugins added in the same image.

Lauren, do you know if Freescale plugin is compatible with gstreamer-imx?

Daiane


\
> +"
> --
> 1.7.9.5
>
> --
> _______________________________________________
> meta-freescale mailing list
> meta-freescale at yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-freescale