[meta-freescale] [meta-fsl-arm][PATCH v2 29/32] gst1.0-fsl-plugins: Upgrade to 4.0.5 version

[Otavio Salvador]

Hello Lauren,

On Thu, Jul 16, 2015 at 4:23 PM, Lauren Post <lauren.post at freescale.com> wrote:
> Upgrade to 4.0.5 version released in 3.14.38-6QP_beta release.
>
> Add the new MX7 SoC family in COMPATIBLE_MACHINE.
>
> Signed-off-by: Lauren Post <lauren.post at freescale.com>

There are mixed changes in this commit, please split them. Inline
comments included.

> ---
>  ...-plugin_4.0.3.bb => gst1.0-fsl-plugin_4.0.5.bb} |   21 +++++++++++++-------
>  1 file changed, 14 insertions(+), 7 deletions(-)
>  rename recipes-multimedia/gstreamer/{gst1.0-fsl-plugin_4.0.3.bb => gst1.0-fsl-plugin_4.0.5.bb} (80%)
>
> diff --git a/recipes-multimedia/gstreamer/gst1.0-fsl-plugin_4.0.3.bb b/recipes-multimedia/gstreamer/gst1.0-fsl-plugin_4.0.5.bb
> similarity index 80%
> rename from recipes-multimedia/gstreamer/gst1.0-fsl-plugin_4.0.3.bb
> rename to recipes-multimedia/gstreamer/gst1.0-fsl-plugin_4.0.5.bb
> index ab28bc1..1c5ac2b 100644
> --- a/recipes-multimedia/gstreamer/gst1.0-fsl-plugin_4.0.3.bb
> +++ b/recipes-multimedia/gstreamer/gst1.0-fsl-plugin_4.0.5.bb
> @@ -17,9 +17,6 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=59530bdf33659b29e73d4adb9f9f6552 \
>                      file://COPYING-LGPL-2.1;md5=fbc093901857fcd118f065f900982c24"
>
>  SRC_URI = "${FSL_MIRROR}/gst1.0-fsl-plugins-${PV}.tar.gz"
> -SRC_URI[md5sum] = "b5c1072536479c174bda1349ade5d10c"
> -SRC_URI[sha256sum] = "9d5c051cbde023014e67fde07bc314b6b9a5e7030e24eb0d8afdf33e7e458125"
> -

Move the new checksums to here. This is where they belong.

>  S = "${WORKDIR}/gst1.0-fsl-plugins-${PV}"
>
>  inherit autotools pkgconfig
> @@ -30,6 +27,7 @@ do_configure[depends] += "virtual/kernel:do_shared_workdir"
>  PLATFORM_mx6 = "MX6"
>  PLATFORM_mx6sl = "MX6SL"
>  PLATFORM_mx6sx = "MX6SX"
> +PLATFORM_mx7= "MX7D"
>
>  # Todo add a mechanism to map possible build targets
>  EXTRA_OECONF = "PLATFORM=${PLATFORM} \
> @@ -38,9 +36,14 @@ EXTRA_OECONF = "PLATFORM=${PLATFORM} \
>
>  PACKAGES =+ "${PN}-gplay ${PN}-libgplaycore ${PN}-libgstfsl"
>
> +SRC_URI[md5sum] = "2ff9d2ddca37a9e119ea137188ef12a3"
> +SRC_URI[sha256sum] = "481aaa11ba443cf33fea5a958fe9f2b278a6815ee92c13407016f9a2407df4d6"
> +

Move up.

>  # Add codec list that the beep plugin run-time depended
>  BEEP_RDEPENDS = "libfslcodec-aac libfslcodec-mp3 libfslcodec-oggvorbis"
> -RDEPENDS_${PN} += "libfslparser ${BEEP_RDEPENDS}"
> +RDEPENDS_${PN} += "libfslparser ${BEEP_RDEPENDS} gstreamer1.0-plugins-good-id3demux"

This is also duplicated.

> +DEPENDS_append = " gstreamer1.0 gstreamer1.0-plugins-base"
> +DEPENDS_append_mx7 = " imx-lib"

Those depends lines are in the wrong place; we have the block in the
begin of the file.

Also there are duplications ... please check it carefully as it seems
that the file has been copied and not verified. :-(

>  PACKAGECONFIG ?= ""
>  PACKAGECONFIG_mx6 = "overlaysink"
> @@ -56,14 +59,18 @@ PACKAGECONFIG[wma8enc] += "--enable-wma8enc,--disable-wma8enc,${MSDEPENDS},${MSD
>  OVDEPENDS = "virtual/libg2d"
>  PACKAGECONFIG[overlaysink] += "--enable-overlaysink,--disable-overlaysink, ${OVDEPENDS}"
>
> -FILES_${PN} = "${libdir}/gstreamer-1.0/*.so ${datadir}"
> -RDEPENDS_${PN} += "gstreamer1.0-plugins-good-id3demux"

Why?

> +# Add grecorder packages
> +PACKAGES += "${PN}-grecorder ${PN}-librecorder_engine"

New packages should be add in the normal block.

> +FILES_${PN} = "${libdir}/gstreamer-1.0/*.so ${datadir}"
>  FILES_${PN}-dbg += "${libdir}/gstreamer-1.0/.debug"
>  FILES_${PN}-dev += "${libdir}/gstreamer-1.0/*.la ${libdir}/pkgconfig/*.pc"
>  FILES_${PN}-staticdev += "${libdir}/gstreamer-1.0/*.a"
>  FILES_${PN}-gplay = "${bindir}/gplay-1.0"
>  FILES_${PN}-libgplaycore = "${libdir}/libgplaycore-1.0${SOLIBS}"
>  FILES_${PN}-libgstfsl = "${libdir}/libgstfsl-1.0${SOLIBS}"
> +FILES_${PN}-grecorder = "${bindir}/grecorder-1.0"
> +FILES_${PN}-librecorder_engine = "${libdir}/librecorder_engine-1.0${SOLIBS}"

${PN}-librecorder-engine please.

> -COMPATIBLE_MACHINE = "(mx6)"
> +PACKAGE_ARCH = "${MACHINE_ARCH}"

The package arch is handled  on the fly, drop please.

> +COMPATIBLE_MACHINE = "(mx6|mx7)"
> --
> 1.7.9.5
>
> --
> _______________________________________________
> meta-freescale mailing list
> meta-freescale at yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-freescale



-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750