[meta-freescale] [meta-fsl-demos][PATCH 1/6] packagegroup-fsl-gstreamer1.0: Create FSL Gstreamer package group

[Daiane Angolini]

On Sat, Jul 11, 2015 at 11:50 AM, Lauren Post <lauren.post at freescale.com> wrote:
> Create package group for Freescale Gstreamer 1.0 plugins.
> This package group provides the Freescale Gstreamer 1.0 Plugins.

I think you can drop one of the sentences. They look the same for me.

>
> Signed-off-by: Lauren Post <lauren.post at freescale.com>
> ---
>  .../packagegroups/packagegroup-fsl-gstreamer1.0.bb |   21 ++++++++++++++++++++
>  1 file changed, 21 insertions(+)
>  create mode 100644 recipes-multimedia/packagegroups/packagegroup-fsl-gstreamer1.0.bb
>
> diff --git a/recipes-multimedia/packagegroups/packagegroup-fsl-gstreamer1.0.bb b/recipes-multimedia/packagegroups/packagegroup-fsl-gstreamer1.0.bb
> new file mode 100644
> index 0000000..1a80940
> --- /dev/null
> +++ b/recipes-multimedia/packagegroups/packagegroup-fsl-gstreamer1.0.bb
> @@ -0,0 +1,21 @@
> +# Copyright (C) 2012-2015 Freescale Semiconductor

I assume it's 2012-2015 because this recipe existed in another
metalayer. It would be nice to say in commit log where is this from,
or change Copyright dating

> +# Released under the MIT license (see COPYING.MIT for the terms)
> +
> +DESCRIPTION = "Freescale package group - gstreamer"

I'm sure you can do a better DESCRIPTION. It really add nothing.

"Packagegroup  with the suggested gstreamer plugins including good,
base, rtsp-server and gplay and grecord in case Freescale's
accelerated plugins are configured"

for example.



Daiane

> +LICENSE = "MIT"
> +
> +PACKAGE_ARCH = "${MACHINE_ARCH}"
> +
> +inherit packagegroup
> +
> +GST_1_X_EXTRA_INSTALL = "gstreamer1.0-plugins-bad-meta"
> +
> +RDEPENDS_${PN} += " \
> +    gstreamer1.0-plugins-good-meta \
> +    gstreamer1.0-plugins-base-meta \
> +    gstreamer1.0-rtsp-server \
> +    ${GST_1_X_EXTRA_INSTALL} \
> +    ${MACHINE_GSTREAMER_1_0_PLUGIN} \
> +    ${@base_contains("MACHINE_GSTREAMER_1_0_PLUGIN", "gst1.0-fsl-plugin", "gst1.0-fsl-plugin-gplay", "", d)} \
> +    ${@base_contains("MACHINE_GSTREAMER_1_0_PLUGIN", "gst1.0-fsl-plugin", "gst1.0-fsl-plugin-grecorder", "", d)} \
> +"
> --
> 1.7.9.5
>
> --
> _______________________________________________
> meta-freescale mailing list
> meta-freescale at yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-freescale