[meta-freescale] [meta-fsl-demos][PATCH 2/6] packagegroup-fsl-gpu-external: Update to support tools on specific SoC

[Max Krummenacher]

Hi Lauren

Am Samstag, den 11.07.2015, 09:50 -0500 schrieb Lauren Post:
> Add glcompbench and gtkperf to the external package group but only
> install on X11 for specific i.MX SoC.  glcompbench not supported on SoloLite.
> Add OpenCV apps and samples to package group.
> Add Wayland support for glmark2 but not for SoloLite.
> 
> Signed-off-by: Lauren Post <lauren.post at freescale.com>
> ---
>  .../packagegroup-fsl-tools-gpu-external.bb         |   27 ++++++++++++++++++++
>  1 file changed, 27 insertions(+)
> 
> diff --git a/recipes-fsl/packagegroups/packagegroup-fsl-tools-gpu-external.bb b/recipes-fsl/packagegroups/packagegroup-fsl-tools-gpu-external.bb
> index 2455084..5a646f4 100644
> --- a/recipes-fsl/packagegroups/packagegroup-fsl-tools-gpu-external.bb
> +++ b/recipes-fsl/packagegroups/packagegroup-fsl-tools-gpu-external.bb
> @@ -17,6 +17,7 @@ SOC_GPU_TOOLS_X11 = " \
>      mesa-demos \
>      glmark2 \
>  "
> +
>  SOC_GPU_TOOLS_X11_append_mx6q  = " eglinfo-x11"
>  SOC_GPU_TOOLS_X11_append_mx6dl = " eglinfo-x11"
>  SOC_GPU_TOOLS_X11_append_mx6sx = " eglinfo-x11"
> @@ -30,10 +31,36 @@ SOC_GPU_TOOLS_WAYLAND = ""
>  
>  SOC_GPU_TOOLS_DIRECTFB = ""
>  
> +# X11 packages
> +X11_TOOLS_INSTALL =  ""
> +X11_TOOLS_GTK = "${@base_contains('DISTRO_FEATURES', 'x11', 'gtkperf', '', d)}"
> +X11_TOOLS_GLCOMP = "${@base_contains('DISTRO_FEATURES', 'x11', 'glcompbench', '', d)}"
> +
> +X11_TOOLS_INSTALL_append_mx6q = " ${X11_TOOLS_GTK} ${X11_TOOLS_GLCOMP}"
> +X11_TOOLS_INSTALL_append_mx6dl = " ${X11_TOOLS_GTK} ${X11_TOOLS_GLCOMP}"
> +X11_TOOLS_INSTALL_append_mx6sx = " ${X11_TOOLS_GTK} ${X11_TOOLS_GLCOMP}"
> +X11_TOOLS_INSTALL_append_mx6sl = " ${X11_TOOLS_GTK}"
Couldn't one use the SOC_GPU_TOOLS_<backend> variable for this, which
already makes the adds the dependencies on SOC and graphical frontend.
e.g.

SOC_GPU_TOOLS_X11_append_mx6q  = " eglinfo-x11 glcompbench gtkperf"

> 
> +
> +# wayland packages
> +
> +WAYLAND_TOOLS_INSTALL =  ""
> +WAYLAND_TOOLS_INSTALL_append_mx6q = "${@base_contains('DISTRO_FEATURES', 'wayland', ' glmark2', '', d)}"
> +WAYLAND_TOOLS_INSTALL_append_mx6dl = "${@base_contains('DISTRO_FEATURES', 'wayland', ' glmark2', '', d)}"
> +WAYLAND_TOOLS_INSTALL_append_mx6sx = "${@base_contains('DISTRO_FEATURES', 'wayland', ' glmark2', '', d)}"
> +

RDEPENDS already contains opencv-samples, but conditional on
"LICENSE_FLAGS_WHITELIST" (https://github.com/Freescale/meta-fsl-demos/commit/21644991533f07ea96a5f7afa2d9aeea394b3cbe)
Wouldn't it make sense to just add opencv-apps in RDEPENDS.

> +# OpenCV test apps
> +OPENCV_TOOLS_INSTALL = ""
> +OPENCV_TOOLS_INSTALL_append_mx6 = "opencv-apps opencv-samples"
> +
> +
> +
>  RDEPENDS_${PN} = " \
>      ${@base_contains("LICENSE_FLAGS_WHITELIST", "commercial", "opencv-samples", "", d)} \
>      ${@base_contains("DISTRO_FEATURES", "x11", "${SOC_GPU_TOOLS_X11}", \
>          base_contains("DISTRO_FEATURES", "wayland", "${SOC_GPU_TOOLS_WAYLAND}", \
>              base_contains("DISTRO_FEATURES", "directfb", "${SOC_GPU_TOOLS_DIRECTFB}", \
>                   "${SOC_GPU_TOOLS_FB}", d), d), d)} \
> +    ${X11_TOOLS_INSTALL} \
> +    ${WAYLAND_TOOLS_INSTALL} \
> +    ${OPENCV_TOOLS_INSTALL} \
>  "
> -- 
> 1.7.9.5
> 

Regards
Max