[meta-freescale] Fwd: [meta-fsl-arm][PATCH v3] Add packagegroup-fsl-bluetooth-tools.bb for handling BlueZ versions.

[Otavio Salvador]

Hello Ann,

(send pressed too soon, sorry)

I will use this patch to illustrate the issues which need rework
immediately. All the other patches has similar issues so please review
them all yourself before sending a new revision of the patchset.

On Mon, Jul 6, 2015 at 1:56 PM, Ann Thornton <ra43240 at freescale.com> wrote:
> BlueZ tools added based on version of BlueZ specified in DISTRO-FEATURES.
>
> Signed-off-by: Ann Thornton <ra43240 at freescale.com>

The commit log is week. The reason of the packagegroup to exist is not
explained.

> ---
>  .../packagegroup-fsl-bluetooth-tools.bb            |   39 ++++++++++++++++++++
>  1 file changed, 39 insertions(+)
>  create mode 100644 recipes-fsl/packagegroups/packagegroup-fsl-bluetooth-tools.bb
>
> diff --git a/recipes-fsl/packagegroups/packagegroup-fsl-bluetooth-tools.bb b/recipes-fsl/packagegroups/packagegroup-fsl-bluetooth-tools.bb
> new file mode 100644
> index 0000000..5a4ad37
> --- /dev/null
> +++ b/recipes-fsl/packagegroups/packagegroup-fsl-bluetooth-tools.bb
> @@ -0,0 +1,39 @@
> +# Copyright (C) 2014-2015 Freescale Semiconductor
> +# Released under the MIT license (see COPYING.MIT for the terms)

This is a new file so 2015 only.

> +SUMMARY = "Freescale package group - bluez Bluetooth tools"
> +DESCRIPTION = "Package group to add bluetooth tools.\
> +   It will add the tools appropiate to the version of BlueZ specified \
> +   in DISTRO_FEATURES. Supports BlueZ4 and BlueZ5"

Same comment of commit log, here.

> +LICENSE = "MIT"
> +LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
> +                    file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
> +
> +inherit packagegroup
> +
> +BLUEZ4_INSTALL = " \
> +    obexftp \
> +"
> +
> +BLUEZ5_INSTALL = " \
> +     bluez5-noinst-tools \
> +     bluez5-obex \
> +     bluez5-testtools  \
> +     libasound-module-bluez \
> +     pulseaudio-module-bluetooth-discover \
> +     pulseaudio-module-bluetooth-policy \
> +     pulseaudio-module-bluez5-discover \
> +     pulseaudio-module-bluez5-device \
> +     pulseaudio-module-switch-on-connect \
> +     pulseaudio-module-loopback \
> +"

Indent is wrong.

Also pulseaudio needs to respect DISTRO_FEATURES as well.

> +# Install either bluez4 or bluez5 if they are in distro.
> +# Otherwise install nothing.
> +BLUEZ_INSTALL = ""

Dead code.

> +BLUEZ_INSTALL = "${@base_contains('DISTRO_FEATURES', 'bluez5', '${BLUEZ5_INSTALL}', \
> +    base_contains('DISTRO_FEATURES', 'bluez4', '${BLUEZ4_INSTALL}', \
> +    '', d), d)}"
> +
> +RDEPENDS_${PN} = ""
> +RDEPENDS_${PN}_mx6 = "${BLUEZ_INSTALL}"

If I have mx28 I cannot use the packagegroup? why?

Also, respect:

http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines

and send all the packagegroup patches in a patchset. Not individual
patches as all those are related.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750