[meta-freescale] [meta-fsl-arm][PATCH 00/11] patches for fsl-qoriq-sdk-v1.8

[Daiane Angolini]

On Mon, Jul 6, 2015 at 8:21 AM, Otavio Salvador <otavio at ossystems.com.br> wrote:
> On Mon, Jul 6, 2015 at 3:29 AM, Liu Ting <ting.liu at freescale.com> wrote:
>>> -----Original Message-----
>>> From: angolini at gmail.com [mailto:angolini at gmail.com] On Behalf Of Daiane
>>> Angolini
>>> Sent: Saturday, July 04, 2015 12:06 AM
>>> To: Liu Ting-B28495
>>> Cc: meta-freescale at yoctoproject.org
>>> Subject: Re: [meta-freescale] [meta-fsl-arm][PATCH 00/11] patches for fsl-
>>> qoriq-sdk-v1.8
>>>
>>> Generally speaking, all the commit logs should be elaborated. However there is
>>> one point which confused me.
>>>
>>> Sometimes, you say "upgrade from XYZ released on SDK1.8", other times you say
>>> "include the following commits from SDK1.8"
>>>
>>> I cannot say if, in second case, you avoided to include some commit present in
>>> SDK1.8 and not upstreamed, or if it's just a language matter.
>> [Liu Ting-B28495] not all the pkgs have clear history to see what changed since the previous commit.
>
> Daiane is, correctly, asking for consistency. The commit logs are
> useful, not now but, in future so they should be as verbose and
> complete as possible.

Exactly, thanks Otavio.

>
>>> Can you, please, double check?
>>>
>>> Regarding the board removed:
>>> >   ls1021aqds: remove as it is not supported
>>> I don't know what to think. It's weird to me to think a board is removed
>>> because a new software is included, why not leave it using the old software?
>> [Liu Ting-B28495] because ls1021aqds was not supported/tested with new software.
>> Do you mean keeping old commit for ls1021aqds, using new commit for the others?
>
> again, please include a clear commit log.

I don't know. Only kill the board is not fair in my point of view.
Does it worked in the past? Why are you killing the board if it worked
in the past? What is the reason behind it being removed?

Maybe a clear commit log is enough to make this removal acceptable.

Daiane
>
> --
> Otavio Salvador                             O.S. Systems
> http://www.ossystems.com.br        http://code.ossystems.com.br
> Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750