[meta-freescale] [meta-fsl-demos][PATCH 1/3] fsl-gpu-sdk: Upgrade to 2.0 version

[Otavio Salvador]

Hello Neena,

Minor comments...

On Wed, Jan 21, 2015 at 2:47 PM, Neena Busireddy
<neena.busireddy at freescale.com> wrote:
> - Supports OpenGL ES2, OpenGL ES3
> - No support for OpenVG and G2D
> - Do not support i.MX6 SoloLite and is intended
>   to add in future
>
> Signed-off-by: Neena Busireddy <neena.busireddy at freescale.com>
> ---
>  .../{fsl-gpu-sdk_1.2.bb => fsl-gpu-sdk_2.0.bb}     |   58 +++++++++-----------
>  1 file changed, 27 insertions(+), 31 deletions(-)
>  rename recipes-graphics/fsl-gpu-sdk/{fsl-gpu-sdk_1.2.bb => fsl-gpu-sdk_2.0.bb} (29%)
>
> diff --git a/recipes-graphics/fsl-gpu-sdk/fsl-gpu-sdk_1.2.bb b/recipes-graphics/fsl-gpu-sdk/fsl-gpu-sdk_2.0.bb
> similarity index 29%
> rename from recipes-graphics/fsl-gpu-sdk/fsl-gpu-sdk_1.2.bb
> rename to recipes-graphics/fsl-gpu-sdk/fsl-gpu-sdk_2.0.bb
> index 021eb77..2e6d2b7 100644
> --- a/recipes-graphics/fsl-gpu-sdk/fsl-gpu-sdk_1.2.bb
> +++ b/recipes-graphics/fsl-gpu-sdk/fsl-gpu-sdk_2.0.bb
> @@ -1,11 +1,12 @@
>  SUMMARY = "Freescale GPU SDK Samples"
>  DESCRIPTION = "Set of sample applications for Freescale GPU"
> -LICENSE = "Proprietary"
> -LIC_FILES_CHKSUM = "file://COPYING;md5=44e96dac83a60d6c21a6055f7b31cf0c"
> -DEPENDS = "virtual/libopenvg ${WL_DEPENDS} ${DFB_DEPENDS}"
> -DEPENDS_append_mx6q = " virtual/libgles1 virtual/libgles2"
> -DEPENDS_append_mx6dl = " virtual/libgles1 virtual/libgles2"
> -DEPENDS_append_mx6sx = " virtual/libgles1 virtual/libgles2"
> +LICENSE = "Apache-2.0"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=cf7b2a944fc10cd1e2471a89ea6b7585"
> +DEPENDS = "${WL_DEPENDS} ${DFB_DEPENDS} "
> +DEPENDS_append_mx6q = " virtual/libgles2"
> +DEPENDS_append_mx6dl = " virtual/libgles2"
> +DEPENDS_append_mx6sx = " virtual/libgles2"
> +
>  WL_DEPENDS = "${@base_contains('DISTRO_FEATURES', 'wayland', 'wayland', '', d)}"
>  DFB_DEPENDS =  "${@base_contains('DISTRO_FEATURES', 'directfb', 'directfb', '', d)}"
>
> @@ -17,38 +18,33 @@ RREPLACES_${PN} = "vivante-gpu-sdk"
>  RCONFLICTS_${PN} = "vivante-gpu-sdk"
>
>  SRC_URI = "${FSL_MIRROR}/${PN}-${PV}.bin;fsl-eula=true"
> -SRC_URI[md5sum] = "9e9bd05dd12c709d8d91ea7ac2445e86"
> -SRC_URI[sha256sum] = "12c78f8c666fdfb1745af9cc22416f03ef670b6ee3db079f6e90e1a3e5ddf0ea"
> -
> -S = "${WORKDIR}/${PN}-${PV}"
>
> -SUPPORTED_APIS = "OpenVG"
> -SUPPORTED_APIS_append_mx6q = " GLES1.1 GLES2.0"
> -SUPPORTED_APIS_append_mx6dl = " GLES1.1 GLES2.0"
> -SUPPORTED_APIS_append_mx6sx = " GLES1.1 GLES2.0"
> +SRC_URI[md5sum] = "c74bba9bfcaf6cb2448c42bb4f597181"
> +SRC_URI[sha256sum] = "8bee7fedc91e054713742d949d749195b6e0cfa3479c1b0168e588a4104d47a9"
>
> -MAKEFILE_NO_X11 = "${@base_contains('DISTRO_FEATURES', 'wayland', 'Makefile.wl', \
> -                                     base_contains('DISTRO_FEATURES', 'directfb', 'Makefile.Dfb', 'Makefile.fbdev', d), d)}"
> -MAKEFILE = "${@base_contains('DISTRO_FEATURES', 'x11', 'Makefile.x11', '${MAKEFILE_NO_X11}', d)}"
> -
> -EXTRA_OEMAKE += "YOCTO_BUILD=1"
> +S = "${WORKDIR}/${PN}-${PV}"

Default, please drop.

> +BACKEND = "${@base_contains('DISTRO_FEATURES', 'x11', 'X11', \
> +                    base_contains('DISTRO_FEATURES', 'wayland', 'Wayland', \
> +                           base_contains('DISTRO_FEATURES', 'directfb', 'DirectFB', 'FB', d), d), d)}"
>  do_compile () {
> -    export ROOTFS=${STAGING_DIR_HOST}
> -    for API in ${SUPPORTED_APIS}; do
> -        cd "${S}/Samples/${API}"
> -        oe_runmake -f "${MAKEFILE}"
> -    done
> +     export FSL_GRAPHICS_SDK=${S}
> +     export FSL_PLATFORM_NAME=Yocto
> +     export ROOTFS=${STAGING_DIR_HOST}
> +    ./build.sh -f GNUmakefile_Yocto EGLBackend=${BACKEND}
>  }
>
>  do_install () {
> -    install -d "${D}/opt/${PN}"
> -    for API in ${SUPPORTED_APIS}; do
> -        cd "${S}/Samples/${API}"
> -        oe_runmake -f "${MAKEFILE}" install
> -        cp -r bin/* "${D}/opt/${PN}"
> -    done
> +   export FSL_GRAPHICS_SDK=${S}
> +   export FSL_PLATFORM_NAME=Yocto
> +   install -d "${D}/opt/${PN}"
> +  ./build.sh -f  GNUmakefile_Yocto EGLBackend=${BACKEND} install
> +   cp -r bin/* "${D}/opt/${PN}"
> +   rm -rf ${D}/opt/${PN}/GLES2/S05_PrecompiledShader
> +   rm -rf ${D}/opt/${PN}/GLES3/S05_PrecompiledShader
>  }

The indenting is mixed. Please use 4 spaces for both do_compile and do_install.

>  FILES_${PN} += "/opt/${PN}"
> -FILES_${PN}-dbg += "/opt/${PN}/*/.debug"
> +FILES_${PN}-dev = "/usr"

Please use ${includedir} or ${libdir} accordingly. /usr shouldn't be hard coded.

> +FILES_${PN}-dbg = "/opt/${PN}/*/*/.debug"
> +INSANE_SKIP_${PN} += "rpaths"
> --
> 1.7.9.5
>
> --
> _______________________________________________
> meta-freescale mailing list
> meta-freescale at yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-freescale



-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750