[meta-freescale] [meta-fsl-arm][PATCH v4 5/6] asf : add recipes for Layerscape1 support

[Sandeep.Malik at freescale.com]

Hi Chunrong,

The "min" and "full" folders contain the dynamic modules of ASF which
will be loaded at the run time. The function of these folders is to
differentiate the two set of binaries on the basis of the functionality.

Regarding the location change suggested from ${libexecdir} to ${bindir}; 
I think as the folders contains dynamic lodable kernel modules and as 
per FHS the modules shall get copied in /lib/modules folder and scripts
can be put in /lib/asf_scripts.

Regards,
Sandeep Malik

> -----Original Message-----
> From: Guo Chunrong-B40290
> Sent: Wednesday, January 07, 2015 7:50 AM
> To: Malik Sandeep-B02416
> Cc: meta-freescale at yoctoproject.org
> Subject: RE: [meta-freescale] [meta-fsl-arm][PATCH v4 5/6] asf : add
> recipes for Layerscape1 support
> 
> Hello Malik Sandeep,
> 
> ${S}/bin/min and ${S}/bin/full are empty folder.
> 
> What is  the function of "min" and "full "  folder ?
> 
> 
> Please review the below comments .
> 
> 
> 
> Thanks
> Chunrong
> 
> 
> -----Original Message-----
> From: meta-freescale-bounces at yoctoproject.org [mailto:meta-freescale-
> bounces at yoctoproject.org] On Behalf Of B40290 at freescale.com
> Sent: Wednesday, January 07, 2015 10:04 AM
> To: Otavio Salvador
> Cc: meta-freescale at yoctoproject.org
> Subject: Re: [meta-freescale] [meta-fsl-arm][PATCH v4 5/6] asf : add
> recipes for Layerscape1 support
> 
> Hello Otavio,
> 
> ${S}/bin/min and ${S}/bin/full are the folder.
> 
> 
> Thanks
> Chunrong
> 
> 
> 
> -----Original Message-----
> From: otavio.salvador at gmail.com [mailto:otavio.salvador at gmail.com] On
> Behalf Of Otavio Salvador
> Sent: Tuesday, January 06, 2015 7:27 PM
> To: Guo Chunrong-B40290
> Cc: meta-freescale at yoctoproject.org
> Subject: Re: [meta-freescale] [meta-fsl-arm][PATCH v4 5/6] asf : add
> recipes for Layerscape1 support
> 
> On Tue, Jan 6, 2015 at 4:42 AM,  <b40290 at freescale.com> wrote:
> > From: Chunrong Guo <B40290 at freescale.com>
> >
> >   1. ASF depend on ipsec-tools in meta-openembeded.
> >   2. ASF is Linux kernel implementation for accelerating the data path
> >       processing on the Freescale family of processors
> >
> > Signed-off-by: Chunrong Guo <B40290 at freescale.com>
> > ---
> >  recipes-kernel/asf/asf_git.bb | 26 ++++++++++++++++++++++++++
> >  1 file changed, 26 insertions(+)
> >  create mode 100644 recipes-kernel/asf/asf_git.bb
> >
> > diff --git a/recipes-kernel/asf/asf_git.bb
> > b/recipes-kernel/asf/asf_git.bb new file mode 100644 index
> > 0000000..57edaca
> > --- /dev/null
> > +++ b/recipes-kernel/asf/asf_git.bb
> > @@ -0,0 +1,26 @@
> > +DESCRIPTION = "Non-DPAA software Application Specific Fast-path"
> > +SECTION = "asf"
> > +LICENSE = "GPLv2 & GPLv2+ & BSD"
> > +LIC_FILES_CHKSUM =
> "file://COPYING;md5=b5881ecf398da8a03a3f4c501e29d287"
> > +
> > +SRC_URI = "git://git.freescale.com/ppc/sdk/asf.git;branch=sdk-v1.7.x"
> > +SRCREV = "16eb472d6b2b34c8b605a86c469611bc8ddec1c9"
> > +
> > +inherit module
> > +
> > +S = "${WORKDIR}/git/asfmodule"
> > +
> > +EXTRA_OEMAKE = "CROSS_COMPILE=${TARGET_PREFIX}"
> > +export KERNEL_PATH = "${STAGING_KERNEL_DIR}"
> > +
> > +INHIBIT_PACKAGE_STRIP = "1"
> > +
> > +do_install(){
> > +       mkdir -p ${D}/${libexecdir}
> > +       cp -rf ${S}/bin/full ${D}/${libexecdir}
> > +       cp -rf ${S}/bin/min  ${D}/${libexecdir}
> > +       cp -rf ${S}/../scripts ${D}/${libexecdir}/.
> > +}
> 
> What about:
> 
> do_install(){
>        mkdir -p ${D}${libexecdir} ${D}${bindir}
>        cp -rf ${S}/bin/full ${D}${bindir}/asf-full
>        cp -rf ${S}/bin/min  ${D}${bindir}/asf-min
>        cp -rf ${S}/../scripts ${D}${libexecdir}/ }
> 
> This would make asf binaries easier to access. Please comment.
> 
> --
> Otavio Salvador                             O.S. Systems
> http://www.ossystems.com.br        http://code.ossystems.com.br
> Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
> --
> _______________________________________________
> meta-freescale mailing list
> meta-freescale at yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-freescale