[meta-freescale] [meta-fsl-arm][PATCH v4] apptrk: add recipes for Layerscape1 support

[Otavio Salvador]

On Tue, Jan 6, 2015 at 12:19 AM,  <b40290 at freescale.com> wrote:
> From: Chunrong Guo <B40290 at freescale.com>
>
>  Userspace debug agent for CodeWarrior
>
> Signed-off-by: Chunrong Guo <B40290 at freescale.com>
> ---
>  ...trk-install-create-all-components-of-DEST.patch | 24 ++++++++++++++++++++++
>  recipes-extended/apptrk/apptrk_git.bb              | 23 +++++++++++++++++++++
>  2 files changed, 47 insertions(+)
>  create mode 100644 recipes-extended/apptrk/apptrk/apptrk-install-create-all-components-of-DEST.patch
>  create mode 100644 recipes-extended/apptrk/apptrk_git.bb
>
> diff --git a/recipes-extended/apptrk/apptrk/apptrk-install-create-all-components-of-DEST.patch b/recipes-extended/apptrk/apptrk/apptrk-install-create-all-components-of-DEST.patch
> new file mode 100644
> index 0000000..6b4a0e8
> --- /dev/null
> +++ b/recipes-extended/apptrk/apptrk/apptrk-install-create-all-components-of-DEST.patch
> @@ -0,0 +1,24 @@
> +Upstream-Status: Pending
> +
> +Signed-off-by: Chunrong Guo <B40290 at freescale.com>
> +
> +
> +  for  fix the following error:
> +  |install: cannot create regular file /usr/bin/apptrk
> +  |No such file or directory
> +
> +
> +--- a/Makefileold      2014-12-21 23:46:26.872329032 -0600
> ++++ b/Makefile 2014-12-21 23:47:33.724326646 -0600
> +@@ -89,9 +89,9 @@
> + # Other Targets
> + install: all
> +       if [ -f $(DESTDIR)/usr/bin/apptrk ]; then rm -f $(DESTDIR)/usr/bin/apptrk ; fi
> +-      install $(OUTPUT) $(DESTDIR)/usr/bin/apptrk
> ++      install -D $(OUTPUT) $(DESTDIR)/usr/bin/apptrk
> +       if [ -f $(DESTDIR)/usr/bin/apptrk_debug ]; then rm -f $(DESTDIR)/usr/bin/apptrk_debug ; fi
> +-      install $(OUTPUT_DBG) $(DESTDIR)/usr/bin/apptrk_debug
> ++      install -D $(OUTPUT_DBG) $(DESTDIR)/usr/bin/apptrk_debug
> +
> + clean:
> +       -$(RM) $(OBJS)$(OBJS_DBG)$(EXECUTABLES)$(C_DEPS)$(C_DEPS_DBG) $(OUTPUT) $(OUTPUT_DBG)
> diff --git a/recipes-extended/apptrk/apptrk_git.bb b/recipes-extended/apptrk/apptrk_git.bb
> new file mode 100644
> index 0000000..7cdf228
> --- /dev/null
> +++ b/recipes-extended/apptrk/apptrk_git.bb
> @@ -0,0 +1,23 @@
> +DESCRIPTION = "Userspace debug agent for ARM CodeWarrior"

The SUMMARY should be:

Debug agent for Freescale CodeWarrior debugger

according to the README in the Git repository.

> +SECTION = "apptrk"
> +LICENSE = "Freescale-EULA"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=95560debfde180684364319811cc1421"
> +
> +DEPENDS = "elfutils"
> +
> +inherit kernel-arch
> +
> +SRC_URI = "git://git.freescale.com/ppc/sdk/apptrk.git;nobranch=1 \
> +    file://apptrk-install-create-all-components-of-DEST.patch \
> +"
> +SRCREV = "cbed10997c5e2a4aaa004fb0e1efec858bf1bbe1"
> +
> +S = "${WORKDIR}/git"
> +
> +CFLAGS += " -I${STAGING_INCDIR} -ISource/Linux -ISource/Portable \
> +                 -ISource/Linux_ARM -ISource/ARM \
> +"

You seem to be duplicating the CFLAGS here[1] and it could be done as:

1. http://git.freescale.com/git/cgit.cgi/ppc/sdk/apptrk.git/tree/Makefile#n52

EXTRA_OEMAKE += "ARCH=${ARCH}"

CFLAGS += "-I${STAGING_INCDIR}"

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750