[meta-freescale] [PATCH v3 3/7] qoriq-base.inc: disable virtual terminal support for QorIQ

[Otavio Salvador]

On Thu, Aug 27, 2015 at 11:02 PM, Luo Zhenhua <zhenhua.luo at freescale.com> wrote:
>> -----Original Message-----
>> From: Otavio Salvador [mailto:otavio.salvador at ossystems.com.br]
>> Sent: Thursday, August 27, 2015 10:07 PM
>> To: Luo Zhenhua-B19537 <zhenhua.luo at freescale.com>
>> Cc: meta-freescale at yoctoproject.org
>> Subject: Re: [meta-freescale] [PATCH v3 3/7] qoriq-base.inc: disable virtual
>> terminal support for QorIQ
>>
>> On Thu, Aug 27, 2015 at 10:56 AM, Luo Zhenhua <zhenhua.luo at freescale.com>
>> wrote:
>> >> -----Original Message-----
>> >> From: Otavio Salvador [mailto:otavio.salvador at ossystems.com.br]
>> >> Sent: Thursday, August 27, 2015 9:37 PM
>> >> To: Luo Zhenhua-B19537 <zhenhua.luo at freescale.com>
>> >> Cc: meta-freescale at yoctoproject.org
>> >> Subject: Re: [meta-freescale] [PATCH v3 3/7] qoriq-base.inc: disable
>> >> virtual terminal support for QorIQ
>> >>
>> >> On Mon, Aug 24, 2015 at 12:31 AM, Zhenhua Luo
>> >> <zhenhua.luo at freescale.com>
>> >> wrote:
>> >> > Signed-off-by: Zhenhua Luo <zhenhua.luo at freescale.com>
>> >>
>> >> To be honest I dislike disabling VT in the BSP but if we do it, it
>> >> needs to be done in the machine files as a new machine should not do that
>> by default.
>> > [Luo Zhenhua-B19537] Since all QorIQ targets don't need VT, I consider it as a
>> common setting for QorIQ targets, instead of adding it in each QorIQ machine
>> conf.
>> >         In future if there is QorIQ machine which should enable VT, it can be
>> overridden in corresponding machine conf, does it make sense?
>>
>> ls1021atwr has HDMI and Usb, why I cannot use VT?
> [Luo Zhenhua-B19537] "disable by default" doesn't mean "not support". Since QorIQ SDK is tested with USE_VT disabled, I added USE_VT ?="0" for all QorIQ targets.
>         Is the following solution OK?
>         Moving USE_VT ?= "0" to qoriq-ppc.inc, accordingly USE_VT is enabled for ls1021a targets.

The point here is that the qoriq include files should describe the
qoriq specifics, not board settings.

So I am not concerning if you will enable or not VT but this should be
in the board file, not the .inc.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750