[meta-freescale] [PATCH] mx6q-ba16: Add initial board support

Daiane Angolini daiane.list at gmail.com
Thu Aug 20 09:31:59 PDT 2015


On Thu, Aug 20, 2015 at 12:56 PM, Justin Waters
<justin.waters at timesys.com> wrote:
> The Advantech DMS-BA16 is a Qseven module containing the i.MX6Q processor.

It would be good if you can elaborate the commit log, maybe use this
as an oportunity to point URLs to the product page or the
documentation.

You can use [1] as example if you feel like.

[1] https://github.com/Freescale/meta-fsl-arm-extra/commit/5fadb641dffe91ec9dedafcb1e27add3e45255dc


>
> Signed-off-by: Justin Waters <justin.waters at timesys.com>
> ---
>  conf/machine/mx6q-ba16.conf                        |  28 ++
>  recipes-bsp/u-boot/u-boot-advantech_git.bb         |  18 ++
>  .../linux-advantech-3.10.17/mx6q-ba16/defconfig    | 336 +++++++++++++++++++++
>  recipes-kernel/linux/linux-advantech_3.10.17.bb    |  16 +

Please, split this commit in 3: One for u-boot, one for kernel, one for machine

>  4 files changed, 398 insertions(+)
>  create mode 100644 conf/machine/mx6q-ba16.conf
>  create mode 100644 recipes-bsp/u-boot/u-boot-advantech_git.bb
>  create mode 100644 recipes-kernel/linux/linux-advantech-3.10.17/mx6q-ba16/defconfig
>  create mode 100644 recipes-kernel/linux/linux-advantech_3.10.17.bb
>
> diff --git a/conf/machine/mx6q-ba16.conf b/conf/machine/mx6q-ba16.conf
> new file mode 100644
> index 0000000..b61c738
> --- /dev/null
> +++ b/conf/machine/mx6q-ba16.conf
> @@ -0,0 +1,28 @@
> +#@TYPE: Machine
> +#@NAME: Advantech MX6Q-BA16
> +#@SOC: i.MX6Q
> +#@DESCRIPTION: Machine configuration for MX6Q-BA16
> +#@MAINTAINER: Justin Waters <justin.waters at timesys.com>
> +
> +include conf/machine/include/imx-base.inc
> +include conf/machine/include/tune-cortexa9.inc
> +
> +SOC_FAMILY = "mx6:mx6q"
> +
> +KERNEL_DEVICETREE = "mx6q-ba16.dtb"
> +KERNEL_IMAGETYPE = "uImage"
> +
> +PREFERRED_PROVIDER_u-boot = "u-boot-advantech"
> +PREFERRED_PROVIDER_virtual/kernel ?= "linux-advantech"
> +PREFERRED_VERSION_linux-advantech ?= "3.10.17"

kernel 3.10.17 is not compatible with the Vivante version in master.
Please, upgrade it at least to 3.10.53

> +
> +# Use SD Card U-Boot by default
> +IMAGE_BOOTLOADER ?= "u-boot"
> +UBOOT_MACHINE ?= "mx6q_ba16_config"
> +
> +SERIAL_CONSOLE = "115200 ttymxc3"
> +
> +MACHINE_FEATURES += " pci"
> +
> +MACHINE_ESSENTIAL_EXTRA_RRECOMMENDS += " kernel-modules "
> +MACHINE_ESSENTIAL_EXTRA_RDEPENDS += " kernel-devicetree "
> diff --git a/recipes-bsp/u-boot/u-boot-advantech_git.bb b/recipes-bsp/u-boot/u-boot-advantech_git.bb
> new file mode 100644
> index 0000000..179f420
> --- /dev/null
> +++ b/recipes-bsp/u-boot/u-boot-advantech_git.bb
> @@ -0,0 +1,18 @@
> +require recipes-bsp/u-boot/u-boot.inc
> +
> +DESCRIPTION = "u-boot for Advantech boards."
> +LICENSE = "GPLv2+"
> +LIC_FILES_CHKSUM = "file://Licenses/README;md5=025bf9f768cbcb1a165dbe1a110babfb"
> +COMPATIBLE_MACHINE = "(mx6q-ba16)"
> +
> +PROVIDES = "u-boot"
> +
> +PV = "v2014.07+git${SRCPV}"
> +
> +SRCREV = "5d5a8c8cee1c82949942c7ca4800fbc12c4dc87c"
> +SRCBRANCH = "2014.07-advantech"
> +SRC_URI = "git://git@github.com/TimesysGit/advantech-u-boot.git;branch=${SRCBRANCH};protocol=ssh"
> +
> +S = "${WORKDIR}/git"
> +
> +PACKAGE_ARCH = "${MACHINE_ARCH}"
> diff --git a/recipes-kernel/linux/linux-advantech-3.10.17/mx6q-ba16/defconfig b/recipes-kernel/linux/linux-advantech-3.10.17/mx6q-ba16/defconfig
> new file mode 100644
> index 0000000..70644e3
> --- /dev/null
> +++ b/recipes-kernel/linux/linux-advantech-3.10.17/mx6q-ba16/defconfig

(...)

> diff --git a/recipes-kernel/linux/linux-advantech_3.10.17.bb b/recipes-kernel/linux/linux-advantech_3.10.17.bb
> new file mode 100644
> index 0000000..b09f618
> --- /dev/null
> +++ b/recipes-kernel/linux/linux-advantech_3.10.17.bb
> @@ -0,0 +1,16 @@
> +# Adapted from linux-imx.inc, copyright (C) 2013, 2014 O.S. Systems Software LTDA
> +# Released under the MIT license (see COPYING.MIT for the terms)
> +
> +require recipes-kernel/linux/linux-imx.inc
> +require recipes-kernel/linux/linux-dtb.inc
> +
> +SUMMARY = "Linux kernel for Advantech boards"

Please, add a DESCRIPTION with more information about why one need a
fork to use your board, and where the fork is from, and I would also
include which Advantech board this kernel support, if it's only one
today, when you upgrade you can include the others.


> +
> +SRC_URI = "git://git@github.com/TimesysGit/advantech-linux.git;branch=${SRCBRANCH};protocol=ssh \
> +           file://defconfig"
> +
> +LOCALVERSION = "-1.0.2_ga+yocto"

Please, use a LOCALVERSION that make sense to you and your users. I
mean, what is the version of this fork, not the version this kernel
was forked from.

> +SRCBRANCH = "3.10.17-advantech"
> +SRCREV = "852aa790665cd8f4350e5efbbb1d3471c78194fd"
> +DEPENDS += "lzop-native bc-native"
> +COMPATIBLE_MACHINE = "(mx6q-ba16)"

Is there a plan to have more imx6 Advantech's boards in future?

Daiane


More information about the meta-freescale mailing list