[meta-freescale] [meta-fsl-arm][PATCH v6] gstreamer1.0-plugins-base: Add gstplaybin related patch

[Otavio Salvador]

On Thu, Aug 6, 2015 at 7:32 AM, Yuqing Zhu <b54851 at freescale.com> wrote:
> -Remove default deinterlace flag in playbin for i.MX s/5/6/7 SoCs.
>
> -Remove native video flag in playbin for i.MX s/5/6/7 SoCs because it will cause subtitle error.
>
> Signed-off-by: Yuqing Zhu <b54851 at freescale.com>
> ---
>  ...video.patch => gstplaybin-remove-flag-deinterlace.patch} | 10 +++++-----
>  .../gstreamer/gstreamer1.0-plugins-base_%.bbappend          | 13 +++++++++----
>  2 files changed, 14 insertions(+), 9 deletions(-)
>  rename recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/{gstplaybin-enable-native-video.patch => gstplaybin-remove-flag-deinterlace.patch} (79%)
>
> diff --git a/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/gstplaybin-enable-native-video.patch b/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/gstplaybin-remove-flag-deinterlace.patch
> similarity index 79%
> rename from recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/gstplaybin-enable-native-video.patch
> rename to recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/gstplaybin-remove-flag-deinterlace.patch
> index 15322bd..f237776 100644
> --- a/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/gstplaybin-enable-native-video.patch
> +++ b/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/gstplaybin-remove-flag-deinterlace.patch
> @@ -1,11 +1,11 @@
>  From 9cfb86cd100904f0ef2626f348695bd2d3416c6a Mon Sep 17 00:00:00 2001
>  From: Jian Li <jian.li at freescale.com>
>  Date: Mon, 23 Jun 2014 14:14:07 +0800
> -Subject: [PATCH] gstplaybin enable native video
> +Subject: [PATCH] gstplaybin remove default deinterlace flag
>
> -- use native video patch in playbin for i.MX SoCs
> +- remove default deinterlace flag in playbin for i.MX SoCs
>
> -Upstream Status: Inappropriate [platform specific]
> +Upstream-Status: Inappropriate [platform specific]
>
>  Signed-off-by: Jian Li <jian.li at freescale.com>
>  ---
> @@ -22,10 +22,10 @@ index fc02ca3..c342438 100644
>   #define DEFAULT_FLAGS             GST_PLAY_FLAG_AUDIO | GST_PLAY_FLAG_VIDEO | GST_PLAY_FLAG_TEXT | \
>  -                                  GST_PLAY_FLAG_SOFT_VOLUME | GST_PLAY_FLAG_DEINTERLACE | \
>  -                                  GST_PLAY_FLAG_SOFT_COLORBALANCE
> -+                                  GST_PLAY_FLAG_SOFT_VOLUME | GST_PLAY_FLAG_NATIVE_VIDEO
> ++                                  GST_PLAY_FLAG_SOFT_VOLUME
>   #define DEFAULT_N_VIDEO           0
>   #define DEFAULT_CURRENT_VIDEO     -1
>   #define DEFAULT_N_AUDIO           0
> ---
> +--
>  1.7.9.5
>
> diff --git a/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base_%.bbappend b/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base_%.bbappend
> index 5b939d4..bc4d3f9 100644
> --- a/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base_%.bbappend
> +++ b/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base_%.bbappend
> @@ -1,9 +1,14 @@
> -
>  FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
>
> -SRC_URI_append_mxs = " file://gstplaybin-enable-native-video.patch"
> -SRC_URI_append_mx5 = " file://gstplaybin-enable-native-video.patch"
> -SRC_URI_append_mx6 = " file://gstplaybin-enable-native-video.patch"
> +SRC_URI_append_mxs = " file://gstplaybin-remove-flag-deinterlace.patch"
> +SRC_URI_append_mx5 = " file://gstplaybin-remove-flag-deinterlace.patch"
> +IMX_PATCHES = " file://gstplaybin-remove-flag-deinterlace.patch \
> +"
> +
> +
> +SRC_URI_append_mx6 = "${IMX_PATCHES}"
> +SRC_URI_append_mx7 = "${IMX_PATCHES}"
> +

Being a single patch it makes no sense to use the var here.

I reworked it so there is no need to resend.

>  PACKAGE_ARCH_mxs = "${MACHINE_SOCARCH}"
>  PACKAGE_ARCH_mx5 = "${MACHINE_SOCARCH}"

You missed this as well; the arch needs to be overridden for all applied SoCs.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750