[meta-freescale] [PATCH v2 0/3] Patch series to add Gateworks Ventana SBCs

Otavio Salvador otavio at ossystems.com.br
Wed Apr 22 05:37:54 PDT 2015


Hello Pushpal,

On Mon, Apr 20, 2015 at 9:03 PM, Pushpal Sidhu <psidhu at gateworks.com> wrote:
> The following is my v2 patch series for adding support for Gateworks Ventana SBCs. The main changes are as follows:
>  * Drop PR in all files
>  * Slightly alter wording of commit messages
>  * Add kernel defconfig
>  * Move machine conf to patch 3/3
>  * Remove do_install in machine conf - keep u-boot-script-gateworks installable via adding it through IMAGE_INSTALL

Thanks for reworking the patchset.

I think we are very close to be able to merge it. I saw two things:

You named some recipes *-gwventana. I would expect them to be
-gateworks as if other boards are later added they can share same
recipe and avoid future renames.

The second thing is the defconfig, of kernel. You need to use
'savedefconfig' to generate the trimmed version. This is way nicer for
updates as it shows the differences clearly (and also aligns with
Kernel upstream style).

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750


More information about the meta-freescale mailing list