[meta-freescale] [meta-fsl-arm-extra][PATCH 3/3] linux-gwventana: Initial linux kernel recipe

[Otavio Salvador]

Hello Pushpal,

Some more comments :)

On Fri, Apr 17, 2015 at 9:04 PM, Pushpal Sidhu <psidhu at gateworks.com> wrote:
> This commit adds a kernel recipe based on Freescale's 3.10.53_1.1.0_ga
> kernel. The defconfig used is located in
> arch/arm/configs/gwventana_config.
>
> Signed-off-by: Pushpal Sidhu <psidhu at gateworks.com>
> ---
>  recipes-kernel/linux/linux-gwventana_3.10.53.bb | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>  create mode 100644 recipes-kernel/linux/linux-gwventana_3.10.53.bb
>
> diff --git a/recipes-kernel/linux/linux-gwventana_3.10.53.bb b/recipes-kernel/linux/linux-gwventana_3.10.53.bb
> new file mode 100644
> index 0000000..81abe89
> --- /dev/null
> +++ b/recipes-kernel/linux/linux-gwventana_3.10.53.bb
> @@ -0,0 +1,23 @@
> +# Copyright (C) 2014 Gateworks Corporation
> +# Released under the MIT license (see COPYING.MIT for the terms)
> +
> +require recipes-kernel/linux/linux-imx.inc
> +require recipes-kernel/linux/linux-dtb.inc
> +
> +PR = "1"

Please drop PR.

> +DEPENDS += "lzop-native bc-native"
> +
> +COMPATIBLE_MACHINE = "(gwventana)"
> +
> +# override URI of source for Gateworks linux-imx kernel

Comment not necessary. All boards do that so people are usually aware of it.

> +SRCREV = "daca48d0edd5e850a956e68facf190b567be9434"
> +LOCALVERSION = "-1.1.0_ga+yocto"

I would drop +yocto but this is personal preference.

> +SRC_URI = "git://github.com/Gateworks/linux-imx6.git;protocol=git;branch=gateworks_3.10.53_1.1.0_ga"
> +
> +# use defconfig from arch/arm/configs
> +# Should note that this defconfig turns off cfg80211 subsystem.
> +# To get those drivers, please build with linux-backports (compat-wireless)
> +do_configure_prepend() {
> +    cp "${S}/arch/arm/configs/gwventana_defconfig" "${WORKDIR}/defconfig"
> +}

Due user friendness we prefer the defconfig to be included verbatim
otherwise people need to prepare patches to change things on it. Take
a look how other boards did ;)

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750