[meta-freescale] [meta-fsl-arm-extra][PATCH 2/3] uboot-gwventana: initial recipe for uboot

[Otavio Salvador]

Hello Pushpal,

There are some possible changes which I want to propose, please look
at the comments inline ...

On Fri, Apr 17, 2015 at 9:04 PM, Pushpal Sidhu <psidhu at gateworks.com> wrote:
> This commit adds the initial recipes for Gateworks Ventana boards. This
> includes a bootscript recipe along with a bootloader recipe.
>
> Signed-off-by: Pushpal Sidhu <psidhu at gateworks.com>

I noticed all comments starts with 'This commit'. This is very picky
but I would start in Adds. So it would be: "Adds initial recipes ..."

> ---
>  recipes-bsp/u-boot/u-boot-gwventana_2014.04.bb     |  15 +++
>  recipes-bsp/u-boot/u-boot-script-gateworks.bb      |  28 ++++
>  .../6x_bootscript-yocto.txt                        | 141 +++++++++++++++++++++
>  3 files changed, 184 insertions(+)
>  create mode 100644 recipes-bsp/u-boot/u-boot-gwventana_2014.04.bb
>  create mode 100644 recipes-bsp/u-boot/u-boot-script-gateworks.bb
>  create mode 100644 recipes-bsp/u-boot/u-boot-script-gateworks/6x_bootscript-yocto.txt
>
> diff --git a/recipes-bsp/u-boot/u-boot-gwventana_2014.04.bb b/recipes-bsp/u-boot/u-boot-gwventana_2014.04.bb
> new file mode 100644
> index 0000000..e733952
> --- /dev/null
> +++ b/recipes-bsp/u-boot/u-boot-gwventana_2014.04.bb
> @@ -0,0 +1,15 @@
> +require recipes-bsp/u-boot/u-boot.inc
> +
> +DESCRIPTION = "U-Boot for Gateworks Ventana Family SBC's"
> +LICENSE = "GPLv2+"
> +LIC_FILES_CHKSUM = "file://Licenses/README;md5=025bf9f768cbcb1a165dbe1a110babfb"
> +DEPENDS = "u-boot-mkimage-native"
> +
> +PR = "r1"

PR is not needed please drop.

> +PV = "v2014.04+git${SRCPV}"
> +
> +SRCREV = "f2a73003969ef178e4734a3658d8295dde63901e"
> +SRC_URI = "git://github.com/Gateworks/u-boot-imx6.git;branch=gateworks_v2014.04"
> +
> +PACKAGE_ARCH = "${MACHINE_ARCH}"
> +COMPATIBLE_MACHINE = "(gwventana)"
> diff --git a/recipes-bsp/u-boot/u-boot-script-gateworks.bb b/recipes-bsp/u-boot/u-boot-script-gateworks.bb
> new file mode 100644
> index 0000000..693ec26
> --- /dev/null
> +++ b/recipes-bsp/u-boot/u-boot-script-gateworks.bb
> @@ -0,0 +1,28 @@
> +LICENSE = "GPLv3"
> +LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/GPL-3.0;md5=c79ff39f19dfec6d293b95dea7b07891"
> +DEPENDS = "u-boot-mkimage-native"
> +
> +PR = "r1"

PR is not needed, please drop.

> +SRC_URI = "file://6x_bootscript-yocto.txt"
> +
> +DESTDIR = "/boot"
> +S = "${WORKDIR}"
> +
> +do_compile() {
> +    bootscript="${THISDIR}/u-boot-script-gateworks/6x_bootscript-yocto.txt"
> +    echo "bootscript == $bootscript"

The echo seems to be a remaining debug trick. Please drop.

...

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750