[meta-freescale] [meta-fsl-arm][PATCH v2 05/15] imx6dlsabresd.conf: Add the imx6dl-sabresd-enetirq device tree

Otavio Salvador otavio at ossystems.com.br
Wed Sep 3 06:20:19 PDT 2014


Hello Lauren,

On Tue, Sep 2, 2014 at 5:07 PM, Lauren Post <lauren.post at freescale.com> wrote:
> Apply ENET IRQ workaround for sabresd board
>
> This is pretty much an example to demonstrate how the GPIO6 workaround
> for bug ERR006687 (ENET: Only the ENET wake-up interrupt request can
> wake the system from Wait mode) should be applied for a board.
>
> Basically it requires a setup of MX6QDL_PAD_GPIO_6__ENET_IRQ in pinctrl
> entry, and an overwrite on the property interrupts-extended to replace
> the ENET GIC IRQ with GPIO1_6.
>
> Since the pad GPIO6 is used by I2C3 on the board, we have to create
> sabresd-enetirq.dts with I2C3 disabled to enable this workaround.
>
> Signed-off-by: Lauren Post <lauren.post at freescale.com>
> ---
>  conf/machine/imx6dlsabresd.conf |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/conf/machine/imx6dlsabresd.conf b/conf/machine/imx6dlsabresd.conf
> index 2407dbc..9d8aff6 100644
> --- a/conf/machine/imx6dlsabresd.conf
> +++ b/conf/machine/imx6dlsabresd.conf
> @@ -9,7 +9,7 @@ require conf/machine/include/imx6sabresd-common.inc
>  SOC_FAMILY = "mx6:mx6dl"
>
>  KERNEL_DEVICETREE = "imx6dl-sabresd.dtb imx6dl-sabresd-ldo.dtb imx6dl-sabresd-hdcp.dtb"
> -KERNEL_DEVICETREE += "imx6dl-sabresd-pf200.dtb"
> +KERNEL_DEVICETREE += "imx6dl-sabresd-pf200.dtb imx6dl-sabresd-enetirq.dtb"

Please use the line break style here as suggested in the SL EVK case.
I really liked you splitted this as it give a rich and informative
commit log on the reasoning but please just rework the code style.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750


More information about the meta-freescale mailing list