[meta-freescale] [meta-fsl-arm-extra][PATCH] imx6dl-riotboard: Add support for RIoT board

[Gary Thomas]

On 2014-10-24 13:09, Fabio Estevam wrote:
> On Fri, Oct 24, 2014 at 4:50 PM, Daiane Angolini
> <daiane.angolini at freescale.com> wrote:
>> Signed-off-by: Daiane Angolini <daiane.angolini at freescale.com>
>
> A brief commit log would be helpful and also a link to
> http://riotboard.org/ could help so people can know the details about
> the board.
>
>> ---
>>   conf/machine/imx6dl-riotboard.conf | 17 +++++++++++++++++
>>   1 file changed, 17 insertions(+)
>>   create mode 100644 conf/machine/imx6dl-riotboard.conf
>>
>> diff --git a/conf/machine/imx6dl-riotboard.conf b/conf/machine/imx6dl-riotboard.conf
>> new file mode 100644
>> index 0000000..fc6dd42
>> --- /dev/null
>> +++ b/conf/machine/imx6dl-riotboard.conf
>> @@ -0,0 +1,17 @@
>> +#@TYPE: Machine
>> +#@NAME: RIoTboard
>> +#@SOC: i.MX6S
>> +#@DESCRIPTION: Machine configuration for i.MX6S RIoTboard.
>> +#@MAINTAINER: Daiane Angolini <daiane.angolini at freescale.com>
>> +
>> +include conf/machine/include/imx-base.inc
>> +include conf/machine/include/tune-cortexa9.inc
>> +
>> +SOC_FAMILY = "mx6:mx6dl"
>> +
>> +UBOOT_MACHINE = "riotboard_defconfig"
>> +
>> +PREFERRED_PROVIDER_virtual/kernel ?= "linux-fslc"
>> +KERNEL_DEVICETREE = "imx6dl-riotboard.dtb"
>> +
>> +SERIAL_CONSOLE = "115200 ttymxc1"
>
> Patch looks good, but just a general comment about SERIAL_CONSOLE: do
> we really need to hardcode the ttymxcX node in the conf files?
>
> Can't this just be passed by the bootloader or via 'stdout-path' in the dts?
>
> If someone wants to test this same rootfs on a board that uses ttymxc0
> then it is not possible due to the mismatch caused by SERIAL_CONSOLE.
>
> What happens if SERIAL_CONSOLE is not passed or if only
> "SERIAL_CONSOLE = "115200" is passed?
>

At least if you are using sysvinit, this is how the choice of
where to put the system login is specified.  (I'm not sure of
systemd - I don't use that)

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------