[meta-freescale] [u-boot-fslc][PATCH] embestmx6boards: Change default bootenv configuration

[Otavio Salvador]

On Wed, Oct 22, 2014 at 1:56 PM, Eric Bénard <eric at eukrea.com> wrote:
> Le Wed, 22 Oct 2014 13:49:54 -0200,
> Otavio Salvador <otavio at ossystems.com.br> a écrit :
>> On Wed, Oct 22, 2014 at 11:12 AM, Eric Bénard <eric at eukrea.com> wrote:
>> > Le Wed, 22 Oct 2014 11:06:31 -0200,
>> > Daiane Angolini <daiane.list at gmail.com> a écrit :
>> >
>> >>
>> >> On Wed, Oct 22, 2014 at 10:37 AM, Fabio Estevam <festevam at gmail.com> wrote:
>> >> > Hi Daiane,
>> >> >
>> >> > On Wed, Oct 22, 2014 at 10:29 AM, Daiane Angolini <daiane.list at gmail.com> wrote:
>> >> >
>> >> >>> why don't you submit it to u-boot mailing list as this board's support
>> >> >>> is mainline and not Yocto centric ?
>> >> >>
>> >> >> I´m not comfortable to upstream this change because I don´t have Mars
>> >> >> board to test it.
>> >> >
>> >> > I agree with Eric's suggestion. Please send the patch to the U-boot
>> >> > list and Cc Eric, as he is the maintainer for the Mars board in U-boot
>> >> > :-)
>> >>
>> >> In this case, I must rework the patch. Do you think both changes can
>> >> share the same patch? Or it would be better to split them?
>> >>
>> >> My reason to change this default value is "to have a smooth boot
>> >> process with sdcard image built from meta-fsl-arm-extra", however it
>> >> does not look good enough to be upstreamed. Would you have a
>> >> suggestion?
>> >>
>> > if that's only meta-fsl-arm-extra focused then I would suggest to simply
>> > add a .bbappend and the patch to your board support inside
>> > meta-fsl-arm-extra.
>>
>> I putted some thought on this and I think it is better to apply this
>> kind of fix in u-boot-fslc repository; this eases the maintenance work
>> of the board, U-Boot and upgrade when newer versions are released.
>>
>> That said, I also think this ought  to be upstreamed and you (Eric)
>> being the board maintainer in U-Boot are in the position to say if it
>> would work for Mars or not. We don't have Mars in meta-fsl-arm-extra
>> so we don't need to worry much about it in the moment from
>> meta-fsl-arm-extra perspective.
>>
>> So I think you (Eric) need to say if you'd be Ok with a patch to
>> change it globally in U-Boot or not.
>>
> my understanding is that this patch is to allow the direct
> boot when booting on an SDcard with u-boot.
>
> The default configuration of u-boot was done to support the eMMC which
> is soldered on the boards.
>
> So in the present case that's a change for a specific usage requiring
> an extra SDCard.
>
> Maybe a more generic solution would be to have a script which
> automatically detects the boot source and adjusts the bootargs
> accordingly.
> Or to generate 2 u-boot binaries : one for the internal eMMC, one for
> the external SD.

Agreed; so I think Daiane's patch can be applied in our fork as
interim solution until we move these board to the new Distro-like
scripts which are available in U-Boot now.


-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750