[meta-freescale] [meta-fsl-demos][PATCH v2] packagegroup-fslc-gstreamer1.0-commercial: remove commercial recipe

[Carlos Rafael Giani]

Sorry, typo. I meant "gstreamer1.0-plugins-ugly-asf" , not 
"gstreamer1.0-plugins-ugly-asfdemux". The -asf package contains the 
libgstasf.so plugin, which in turn contains the asfdemux element.

On 2014-11-25 23:22, Carlos Rafael Giani wrote:
> Hm, I am not sure how this came to be. Anyway, you are correct that 
> mpg123 is not part of -ugly, so this entry should be removed.
> However, there is a "gstreamer1.0-plugins-ugly-asfdemux" package from 
> -ugly, which does belong here. Also, I think perhaps we could
> move this line from the -full to the -commercial packagegroup:
>
> ${@base_contains('LICENSE_FLAGS_WHITELIST', 'commercial', 
> 'gstreamer1.0-libav', '', d)}
>
> I think this makes more sense. Comments?
>
> On 2014-11-21 17:58, Alexander Shashkevych wrote:
>> packagegroup-fslc-gstreamer1.0-commercial had a dependencies on
>> following missing packages:
>>
>>     gstreamer1.0-plugins-ugly-mpg123
>>     gstreamer1.0-plugins-ugly-asfdemux
>>
>> Both of these packages are no longer provided by community. The
>> mpg123 plugin is now a part of bad plugins set and this leads to build
>> fail when commercial license is selected.
>>
>> This change removes packagegroup-fslc-gstreamer1.0-commercial recipe.
>>
>> Signed-off-by: Alexander Shashkevich <alex at stunpix.com>
>> ---
>>   .../packagegroup-fslc-gstreamer1.0-commercial.bb     | 20 
>> --------------------
>>   .../packagegroup-fslc-gstreamer1.0-full.bb           |  1 -
>>   2 files changed, 21 deletions(-)
>>   delete mode 100644
>> recipes-multimedia/packagegroups/packagegroup-fslc-gstreamer1.0-commercial.bb 
>>
>>
>> diff --git 
>> a/recipes-multimedia/packagegroups/packagegroup-fslc-gstreamer1.0-commercial.bb
>> b/recipes-multimedia/packagegroups/packagegroup-fslc-gstreamer1.0-commercial.bb 
>>
>> deleted file mode 100644
>> index f33c3d8..0000000
>> --- 
>> a/recipes-multimedia/packagegroups/packagegroup-fslc-gstreamer1.0-commercial.bb
>> +++ /dev/null
>> @@ -1,20 +0,0 @@
>> -DESCRIPTION = "Freescale package group which provides audio and 
>> video plugins \
>> - that are subject to retricted licensing and/or royalties and thus 
>> require \
>> - the 'commercial' license whitelist flag"
>> -SUMMARY = "Freescale package group - set of GStreamer 1.0 plugins
>> with commercial licence flag"
>> -LICENSE = "MIT"
>> -LICENSE_FLAGS = "commercial"
>> -LIC_FILES_CHKSUM =
>> "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
>> -
>> file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420" 
>>
>> -
>> -inherit packagegroup
>> -
>> -RDEPENDS_${PN} = " \
>> -    packagegroup-fslc-gstreamer1.0 \
>> -"
>> -
>> -# Plugins from the -ugly collection which require the "commercial"
>> flag in LICENSE_FLAGS_WHITELIST to be set
>> -RDEPENDS_${PN} = " \
>> -    gstreamer1.0-plugins-ugly-mpg123 \
>> -    gstreamer1.0-plugins-ugly-asfdemux \
>> -"
>> diff --git 
>> a/recipes-multimedia/packagegroups/packagegroup-fslc-gstreamer1.0-full.bb
>> b/recipes-multimedia/packagegroups/packagegroup-fslc-gstreamer1.0-full.bb 
>>
>> index 4dd3d77..d99431a 100644
>> --- 
>> a/recipes-multimedia/packagegroups/packagegroup-fslc-gstreamer1.0-full.bb
>> +++ 
>> b/recipes-multimedia/packagegroups/packagegroup-fslc-gstreamer1.0-full.bb
>> @@ -10,7 +10,6 @@ inherit packagegroup
>>
>>   RDEPENDS_${PN} = " \
>>       packagegroup-fslc-gstreamer1.0 \
>> -    ${@base_contains('LICENSE_FLAGS_WHITELIST', 'commercial',
>> 'packagegroup-fslc-gstreamer1.0-commercial', '', d)} \
>>       gstreamer1.0-plugins-base-meta \
>>       gstreamer1.0-plugins-good-meta \
>>       gstreamer1.0-plugins-bad-meta \
>