[meta-freescale] [meta-fsl-arm][PATCH] xf86-video-imxfb-vivante: fix build with xserver 1.16

[Otavio Salvador]

Hello Andreas,

On Thu, Nov 13, 2014 at 12:53 PM, Andreas Müller
<schnitzeltony at googlemail.com> wrote:
> Xserver 1.16 is close: angstrom is already using it and oe-core patches are
> pending.
>
> DisplayModePtr member 'name' was made constant in
> xserver:
>
> commit 27b44949a3d2e34ac10e801bd8a8fc2c28791e7e
> Author: Keith Packard <keithp at keithp.com>
> Date:   Fri Nov 15 16:24:15 2013 +0900
>
>     hw/xfree86: Lots of constant string support
>
>     Make lots of string pointers 'const char' so that we can use constant
>     strings with them without eliciting warnings.
>
>     Signed-off-by: Keith Packard <keithp at keithp.com>
>     Reviewed-by: Adam Jackson <ajax at redhat.com>
>
> Tested with xserver 1.16 but the casts should work with 1.15 too.
>
> Signed-off-by: Andreas Müller <schnitzeltony at googlemail.com>

Wanderful! :-)

...
> +++ b/recipes-graphics/xorg-driver/xf86-video-imxfb-vivante/0001-casts-to-fix-build-with-xserver-1.16.patch
> @@ -0,0 +1,57 @@
> +From e95239b803deabcfe62fa7fc2027b6872b3cc556 Mon Sep 17 00:00:00 2001
> +From: =?UTF-8?q?Andreas=20M=C3=BCller?= <schnitzeltony at googlemail.com>
> +Date: Thu, 13 Nov 2014 15:14:09 +0100
> +Subject: [PATCH] casts to fix build with xserver 1.16
> +MIME-Version: 1.0
> +Content-Type: text/plain; charset=UTF-8
> +Content-Transfer-Encoding: 8bit
> +
> +vivante_fbdev/vivante_fbdev_driver.c:1641:22: error: assignment discards 'const' qualifier from pointer target type [-Werror]
> +             modeName = pScrn->currentMode->name;
> +                      ^
> +vivante_fbdev/imx_display.c: In function 'imxDisplayDeleteModes':
> +vivante_fbdev/imx_display.c:959:4: error: passing argument 1 of 'free' discards 'const' qualifier from pointer target type [-Werror]
> +    free(mode->name);
> +    ^
> +In file included from ./vivante_util/vivante_common.h:30:0,
> +                 from vivante_fbdev/imx_display.c:25:
> +/home/a.mueller/tmp/oe-core-glibc/sysroots/varsomimx6q/usr/include/stdlib.h:483:13: note: expected 'void *' but argument is of type 'const char *'
> + extern void free (void *__ptr) __THROW;
> +             ^
> +cc1: all warnings being treated as errors
> +
> +Signed-off-by: Andreas Müller <schnitzeltony at googlemail.com>

It is lacking the Upstream-Status: Pending field.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750