[meta-freescale] [meta-fsl-arm][PATCH] imx-vpu: fix checks of IOGetVirtMem() return value
Otavio Salvador
otavio at ossystems.com.br
Wed Jun 25 09:18:41 PDT 2014
Hello Eric,
Hello Lauren,
On Sat, Jun 21, 2014 at 2:52 PM, Eric Nelson
<eric.nelson at boundarydevices.com> wrote:
> The IOGetVirtMem() routine returns the address of a memory block
> or -1 (MAP_FAILED) to indicate an error.
>
> Many callers of this routine tested the return value for <= 0
> to detect failure, and at least with a 3G/1G memory split
> configured in the kernel, a negative number (!= -1) is a
> valid (successful) return value.
>
> Without this patch, the IOSystemInit() will often detect
> failure incorrectly.
>
> Signed-off-by: Eric Nelson <eric.nelson at boundarydevices.com>
Eric, you forgot the add the upstream-status field as:
diff --git a/recipes-bsp/imx-vpu/imx-vpu/0001-IOGetVirtMem-returns-1-MAP_FAILED-on-failure.patch
b/recipes-bsp/imx-vpu/imx-vpu/0001-IOGetVirtMem-returns-1-MAP_FAILED-on-failure.patch
index 26826ba..348a536 100644
--- a/recipes-bsp/imx-vpu/imx-vpu/0001-IOGetVirtMem-returns-1-MAP_FAILED-on-failure.patch
+++ b/recipes-bsp/imx-vpu/imx-vpu/0001-IOGetVirtMem-returns-1-MAP_FAILED-on-failure.patch
@@ -3,6 +3,8 @@ From: Eric Nelson <eric.nelson at boundarydevices.com>
Date: Fri, 20 Jun 2014 19:42:38 -0700
Subject: [PATCH] IOGetVirtMem returns -1 (MAP_FAILED) on failure
+Upstream-Status: Pending
+
Signed-off-by: Eric Nelson <eric.nelson at boundarydevices.com>
---
vpu/vpu_io.c | 2 +-
I have done it here, so no need to resend it but please do it next time.
Lauren, this patch should be reviewed internally.
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
More information about the meta-freescale
mailing list