[meta-freescale] [meta-fsl-arm][PATCH 1/3] pulseaudio: Customize pulseaudio configuration for i.MX platforms

[junzhu at freescale.com]

-----Original Message-----
From: otavio.salvador at gmail.com [mailto:otavio.salvador at gmail.com] On Behalf Of Otavio Salvador
Sent: Tuesday, July 29, 2014 9:38 PM
To: Zhu Jun-R01007
Cc: meta-freescale at yoctoproject.org
Subject: Re: [meta-freescale] [meta-fsl-arm][PATCH 1/3] pulseaudio: Customize pulseaudio configuration for i.MX platforms

Hello Jun,

On Tue, Jul 29, 2014 at 4:04 AM, Jun Zhu <R01007 at freescale.com> wrote:
> on i.MX seriese boards, some pulseaudio defualt setting should be 
> modified to improve the user experience:
>  - Daemon's exit_idle_time: set value as -1 to make pulseaudio service 
> never be terminated by any user-space app.
>  - Resample mothed: switch to the build-in ffmpeg to improve the sound 
> quality.
>  - Flat_Volumes: set value as "no" to align with the normal use case.
>
> These customized configuration would be installed to overwrite the 
> original version.
>
> Signed-off-by: Jun Zhu <R01007 at freescale.com>

Your subject say's i.MX. Does it imply you tested it in all i.MX platforms? Or this has been tested in i.MX6 only?
[Zhu Jun-R01007] It is only tested on i.Mx6, so I will adjust it in Patch v2

You seem to rely in ffmpeg, I fear this has license implications, does it not?
[Zhu Jun-R01007] PulseAudio has a built-in resample library from ffmpeg and code can be found under pulseaudio-5.0/src/pulsecore/ffmpeg. So it may not causes the license problem.

You patch needs to be adjusted to not include this files for other machines. Please rework it.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750