[meta-freescale] [meta-fsl-arm-extra][PATCH v3 3/3] cubox-i: add machine config

[Otavio Salvador]

Hello Carlos,

Comments inline ...

On Fri, Jan 24, 2014 at 5:57 PM, Carlos Rafael Giani
<dv at pseudoterminal.org> wrote:
> The new cubox-i machine config produces images that can be used for
> all CuBox-i and HummingBoard devices (u-boot SPL autodetects the platform)
>
> Signed-off-by: Carlos Rafael Giani <dv at pseudoterminal.org>
> ---
>  conf/machine/cubox-i.conf | 28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
>  create mode 100644 conf/machine/cubox-i.conf
>
> diff --git a/conf/machine/cubox-i.conf b/conf/machine/cubox-i.conf
> new file mode 100644
> index 0000000..f08194f
> --- /dev/null
> +++ b/conf/machine/cubox-i.conf
> @@ -0,0 +1,28 @@
> +#@TYPE: Machine
> +#@NAME: SolidRun CuBox-i
> +#@SOC: i.MX6 Q/DL/S
> +#@DESCRIPTION: Machine configuration for SolidRun CuBox-i and HummingBoard machines
> +
> +# Machine config for the SolidRun CuBox-i and HummingBoard machines.
> +# They all use the same machine config, since the u-boot SPL autodetects the
> +# machine type upon booting. SOC_FAMILY includes all SoCs from all of these machines
> +# to let recipes include firmware etc. for all of these SoCs.
> +
> +require conf/machine/include/imx6sabresd-common.inc
> +
> +SOC_FAMILY = "mx6:mx6s:mx6dl:mx6q"
> +
> +PREFERRED_PROVIDER_u-boot = "u-boot-cubox-i"
> +PREFERRED_PROVIDER_virtual/kernel = "linux-cubox-i"
> +
> +UBOOT_MAKE_TARGET = ""
> +UBOOT_SUFFIX = "img"
> +UBOOT_ENTRYPOINT = "0x10800000"
> +UBOOT_CONFIG ??= "sd"
> +UBOOT_CONFIG[sd] = "mx6_cubox-i_config,sdcard"
> +UENV_FILENAME = "uEnv-${MACHINE}.txt"
> +SPL_BINARY = "SPL"
> +
> +BOOT_SCRIPTS = "${UENV_FILENAME}:uEnv.txt"
> +
> +MACHINE_FEATURES += " alsa bluetooth irda serial usbhost wifi"

Please, drop the 'space' just before alsa. The += operator does
support the list accordingly so it is redundant.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750