[meta-freescale] [PATCH 2/4] cubox-i: add customized kernel

[Otavio Salvador]

On Wed, Jan 22, 2014 at 2:45 PM, Carlos Rafael Giani
<dv at pseudoterminal.org> wrote:
> This kernel is based on linux-imx 3.0.35, and adds patches for
> CuBox-i and HummingBoard support
>
> Signed-off-by: Carlos Rafael Giani <dv at pseudoterminal.org>
...
> +++ b/recipes-kernel/linux/linux-imx-3.0.35/cubox-i/fix-install-breakage-for-fw-images.patch
> @@ -0,0 +1,30 @@
> +From f6a15304bc2730ba091eb747c413d4ef4124565e Mon Sep 17 00:00:00 2001
> +From: Denys Dmytriyenko <denys at ti.com>
> +Date: Mon, 5 Mar 2012 16:34:53 -0500
> +Subject: [PATCH] Makefile.fwinst: fix install breakage for FW images residing
> + in firmware/ dir
> +
> +This fixes below error found on some distros (Gentoo and Fedora):
> +*** No rule to make target `lib/firmware/./', needed by `lib/firmware/ti_3410.fw'.  Stop.
> +
> +Signed-off-by: Denys Dmytriyenko <denys at ti.com>

Please add:

Upstream-Status: Pending

> diff --git a/recipes-kernel/linux/linux-imx-3.0.35/cubox-i/mxc_hdmi-dont-require-cea-mode.patch b/recipes-kernel/linux/linux-imx-3.0.35/cubox-i/mxc_hdmi-dont-require-cea-mode.patch
> new file mode 100644
> index 0000000..817c1e0

Please add:

Upstream-Status: Pending

And a small description why this patch is need.

> --- /dev/null
> +++ b/recipes-kernel/linux/linux-imx-3.0.35/cubox-i/mxc_hdmi-dont-require-cea-mode.patch
> @@ -0,0 +1,18 @@
> +diff --git a/drivers/video/mxc_hdmi.c b/drivers/video/mxc_hdmi.c
> +index 544f352..fa67128 100644
> +--- a/drivers/video/mxc_hdmi.c
> ++++ b/drivers/video/mxc_hdmi.c
> +@@ -1804,10 +1804,10 @@ static void mxc_hdmi_edid_rebuild_modelist(struct mxc_hdmi *hdmi)
> +                */
> +               mode = &hdmi->fbi->monspecs.modedb[i];
> +
> +-              if (!(mode->vmode & FB_VMODE_INTERLACED) &&
> +-                              (mxc_edid_mode_to_vic(mode) != 0)) {
> ++              if (!(mode->vmode & FB_VMODE_INTERLACED)) {
> ++                      int vic = mxc_edid_mode_to_vic(mode);
> +
> +-                      dev_dbg(&hdmi->pdev->dev, "Added mode %d:", i);
> ++                      dev_info(&hdmi->pdev->dev, "%s: Added mode %d(VIC %u):", __func__, i, vic);

Bogus change.

> +                       dev_dbg(&hdmi->pdev->dev,
> +                               "xres = %d, yres = %d, freq = %d, vmode = %d, flag = %d\n",
> +                               hdmi->fbi->monspecs.modedb[i].xres,
> diff --git a/recipes-kernel/linux/linux-imx_3.0.35.bbappend b/recipes-kernel/linux/linux-imx_3.0.35.bbappend
> index dca3b92..c68b7cb 100644
> --- a/recipes-kernel/linux/linux-imx_3.0.35.bbappend
> +++ b/recipes-kernel/linux/linux-imx_3.0.35.bbappend
> @@ -1,6 +1,6 @@
>  FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}-${PV}:"
>
> -PRINC := "${@int(PRINC) + 5}"
> +PRINC := "${@int(PRINC) + 6}"

Please don't update this.

You are mostly redoing all the recipe I'd prefer you to make a
linux-cubox-i recipe and avoid the revision override and like. The
linux-imx here is used when there's no Git tree we can use.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750