[meta-freescale] [meta-fsl-demos][PATCH 4/7] packagegroup-fsl-*, fsl-image-*: Gstreamer packagegroup refactoring

[Daiane.Angolini at freescale.com]

> -----Original Message-----
> From: meta-freescale-bounces at yoctoproject.org [mailto:meta-freescale-
> bounces at yoctoproject.org] On Behalf Of Rogerio Nunes
> Sent: Wednesday, February 26, 2014 2:47 PM
> To: Daiane Angolini
> Cc: meta-freescale at yoctoproject.org; Nunes Rogerio-B35650
> Subject: Re: [meta-freescale] [meta-fsl-demos][PATCH 4/7] packagegroup-fsl-
> *, fsl-image-*: Gstreamer packagegroup refactoring
> 
> On Wed, Feb 26, 2014 at 11:08 AM, Daiane Angolini <daiane.list at gmail.com>
> wrote:
> > On Wed, Feb 26, 2014 at 2:03 AM,  <ronunes at gmail.com> wrote:
> >> From: Rogerio Nunes <rogerio.nunes at freescale.com>
> >>
> >> This patch refactors packagegroup-fsl-gstreamer, bringing code from
> >> gst-meta-base. This change makes this packagegroup more flexible and
> >> prepares it for further changes. Also, as gst-meta-base explicitly
> >> depends on gst-plugins-bad, and this dependency is not present in
> >> packagegroup-fsl-gstreamer, build time for this pakagegroup has
> >> improved.
> >>
> >> This patch also creates the packagegroup-fsl-gstreamer-full
> >> packagegroup, which can be used to add all the available plugins to
> >> an image, including bad plugins and ugly plugins when 'commercial' is
> >> present in the license whitelist.
> >>
> >> Gstreamer tools are removed from packagegroup-fsl-tools-testapps, so
> >> now this packagegroup does not need to be machine dependent anymore.
> >>
> >> Finally, this patch adds gst-plugins-good-meta to fsl-image-* images,
> >> so that the images still have the same list of gstreamer plugins
> >> available.
> >>
> >
> > lovely commit log <3
> >
> >> Signed-off-by: Rogerio Nunes <rogerio.nunes at freescale.com>
> >> ---
> >>  recipes-fsl/images/fsl-image-gui.bb                |  1 +
> >>  recipes-fsl/images/fsl-image-test.bb               |  1 +
> >>  .../packagegroup-fsl-gstreamer-full.bb             | 19 +++++++
> >>  .../packagegroups/packagegroup-fsl-gstreamer.bb    | 66
> ++++++++++++++++++++--
> >>  .../packagegroup-fsl-tools-testapps.bb             |  6 --
> >>  5 files changed, 82 insertions(+), 11 deletions(-)  create mode
> >> 100644 recipes-fsl/packagegroups/packagegroup-fsl-gstreamer-full.bb
> >>
> >> diff --git a/recipes-fsl/images/fsl-image-gui.bb
> >> b/recipes-fsl/images/fsl-image-gui.bb
> >> index 5441272..666475a 100644
> >> --- a/recipes-fsl/images/fsl-image-gui.bb
> >> +++ b/recipes-fsl/images/fsl-image-gui.bb
> >> @@ -23,6 +23,7 @@ IMAGE_INSTALL += " \
> >>      cpufrequtils \
> >>      nano \
> >>      packagegroup-fsl-gstreamer \
> >> +    gst-plugins-good-meta \
> >>      packagegroup-fsl-tools-gpu \
> >>      packagegroup-fsl-tools-gpu-external \
> >>      packagegroup-fsl-tools-testapps \ diff --git
> >> a/recipes-fsl/images/fsl-image-test.bb
> >> b/recipes-fsl/images/fsl-image-test.bb
> >> index 2570ac9..0408c7c 100644
> >> --- a/recipes-fsl/images/fsl-image-test.bb
> >> +++ b/recipes-fsl/images/fsl-image-test.bb
> >> @@ -14,6 +14,7 @@ EXTRA_IMAGE_FEATURES += " \
> >>
> >>  IMAGE_INSTALL += " \
> >>      packagegroup-fsl-gstreamer \
> >> +    gst-plugins-good-meta \
> >>      packagegroup-fsl-tools-gpu \
> >>      packagegroup-fsl-tools-gpu-external \
> >>      packagegroup-fsl-tools-testapps \ diff --git
> >> a/recipes-fsl/packagegroups/packagegroup-fsl-gstreamer-full.bb
> >> b/recipes-fsl/packagegroups/packagegroup-fsl-gstreamer-full.bb
> >> new file mode 100644
> >> index 0000000..3ed5d6f
> >> --- /dev/null
> >> +++ b/recipes-fsl/packagegroups/packagegroup-fsl-gstreamer-full.bb
> >> @@ -0,0 +1,19 @@
> >> +# Copyright (C) 2014 Freescale Semiconductor # Released under the
> >> +MIT license (see COPYING.MIT for the terms)
> >> +
> >> +DESCRIPTION = "Freescale package group - gstreamer full"
> >> +LICENSE = "MIT"
> >> +LIC_FILES_CHKSUM =
> "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
> >> +
> file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
> >> +
> >> +inherit packagegroup
> >> +
> >> +RDEPENDS_${PN} = " \
> >> +    packagegroup-fsl-gstreamer \
> >> +    gst-plugins-base-meta \
> >> +    gst-plugins-good-meta \
> >> +    gst-plugins-bad-meta \
> >> +    ${@base_contains('DISTRO_FEATURES', 'opengl', \
> >> +                      base_contains('DISTRO_FEATURES', 'x11', \
> >> +                                    'gst-plugins-gl', '', d), '',
> >> +d)} \ "
> >
> > why do you decided to use 3 lines to add this base_contains line?
> > #weird
> >
> > other than that, I don´t have comments ;-)
> 
> Only because there is a base_contain call inside another base_contain call,
> so I thought it would be more readable this way. Besides a single line was
> too big.
> If you don't mind, I'd rather keep three lines.

I don´t mind ;)

Daiane