[meta-freescale] [meta-fsl-arm][PATCH 2/3] libmcc: Rework recipe

[Otavio Salvador]

Hello Daiane,

On Mon, Feb 24, 2014 at 10:37 AM, Daiane.Angolini at freescale.com
<Daiane.Angolini at freescale.com> wrote:
>
>
>> -----Original Message-----
>> From: meta-freescale-bounces at yoctoproject.org [mailto:meta-freescale-
>> bounces at yoctoproject.org] On Behalf Of Otavio Salvador
>> Sent: Monday, February 24, 2014 9:10 AM
>> To: meta-freescale Mailing List
>> Cc: Otavio Salvador
>> Subject: [meta-freescale] [meta-fsl-arm][PATCH 2/3] libmcc: Rework recipe
>>
>> - Use summary as the description was short
>> - Drop vendor name from summary
>> - Put RDEPENDS after source fields
>> - Add empty line between S and CFLAGS
>> - Drop extra space in CFLAGS appending
>
> It took me more than 5 seconds to realize what this patch does.
> I think you can improve this commit subject and commit log with something like:
>
> "libmcc: Add minor changes to get recipe in better shape"
>
>
> And
>
> "In order to use the same pattern from other recipes, the following changes were
> made in recipe:
>
>> - Use summary as the description was short
>> - Drop vendor name from summary
>> - Put RDEPENDS after source fields
>> - Add empty line between S and CFLAGS
>> - Drop extra space in CFLAGS appending
> "

Thanks for the advice; it does fits better.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750