[meta-freescale] [meta-fsl-arm][PATCH] fixed error in 0001-Initial-porting-effort-to-GStreamer-1.0.patch

Otavio Salvador otavio at ossystems.com.br
Fri Dec 12 06:31:44 PST 2014


Hello Mingtao,

On Fri, Dec 12, 2014 at 1:22 AM, zarelaky <zarelaky at hotmail.com> wrote:
> From: Mingtao Qu <zarelaky at hotmail.com>
>
>     gstreamer0.10 GstCap parameter 'format' use wrong type 'G_TYPE_STRING' cause
>     gstreamer0.10 crash.
>
> Signed-off-by: Mingtao Qu <zarelaky at hotmail.com>

I agree with the patch. Before we merge it, please rework the commit
log... something which explain /why/ you are fixing it:

qtmultimedia: Fix crash when using GStreamer 0.10 plugin

The GStreamer plugin uses a wrong type for 'format' parameter of
GstCap when using the 0.10 GStreamer version. This patch fixes the
parameter type to use GST_TYPE_FOURCC as expected.

Signed-off-by: ...

This is just one example, don't take this as final but please extend it a bit.


-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750


More information about the meta-freescale mailing list