[meta-freescale] [meta-fsl-arm][PATCH v2 1/6] Add common configure files for Layerscape1 support

[Otavio Salvador]

On Thu, Aug 28, 2014 at 7:44 AM, zhenhua.luo at freescale.com
<zhenhua.luo at freescale.com> wrote:
>> -----Original Message-----
>> From: otavio.salvador at gmail.com [mailto:otavio.salvador at gmail.com] On
>> Behalf Of Otavio Salvador
>> Sent: Wednesday, August 27, 2014 8:47 PM
>>
>> On Wed, Aug 27, 2014 at 1:57 AM, Zhenhua Luo <zhenhua.luo at freescale.com>
>> wrote:
>> > diff --git a/conf/machine/include/fsl-ls-default-settings.inc
>> > b/conf/machine/include/fsl-ls-default-settings.inc
>> > new file mode 100644
>> > index 0000000..45ca43a
>> > --- /dev/null
>> > +++ b/conf/machine/include/fsl-ls-default-settings.inc
>> > @@ -0,0 +1,4 @@
>> > +# Freescale BSP default settings
>> > +
>> > +IMAGE_CLASSES = "image_types_uboot"
>>
>> Does ALL machines using ls going to use this? I'd prefer this to be in
>> machine file.
> [Luo Zhenhua-B19537] Current supported ls1 targets use the same setting, the variable will be moved to machine conf if there is special case in future.
>
>> > +SERIAL_CONSOLES ?= "115200;ttyS0 115200;ttyS1 115200;ttyEHV0
>> 115200;ttyLP0"
>> > +SERIAL_CONSOLES_CHECK ?= "${SERIAL_CONSOLES}"
>>
>> Those ought to be in machine files. This vary from one machine to another.
>>
>> > +USE_VT ?= "0"
>> This is default.
> [Luo Zhenhua-B19537] I double-checked the sysvinit-inittab recipe, the default value of USE_VT is "1", so the item should be here.

I'd prefer to have those in the machine file. I understand why you
want to disable it but this should be done on the machine file not in
a .inc file.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750