[meta-freescale] [meta-fsl-arm][PATCH v2 3/6] Add kernel recipe for Layerscape1 support

[zhenhua.luo at freescale.com]

> -----Original Message-----
> From: otavio.salvador at gmail.com [mailto:otavio.salvador at gmail.com] On
> Behalf Of Otavio Salvador
> Sent: Wednesday, August 27, 2014 9:01 PM
> 
> On Wed, Aug 27, 2014 at 1:57 AM, Zhenhua Luo <zhenhua.luo at freescale.com>
> wrote:
> > +
> > +do_configure_prepend() {
> > +    # copy desired defconfig so we pick it up for the real
> kernel_do_configure
> > +    cp ${KERNEL_DEFCONFIG} ${B}/.config
> > +
> > +    # add git revision to the local version
> > +    if [ "${SCMVERSION}" = "y" ]; then
> > +        # append sdk version if SDK_VERSION is defined
> > +        sdkversion=''
> > +        if [ -n "${SDK_VERSION}" ]; then
> > +            sdkversion="-${SDK_VERSION}"
> > +        fi
> > +        head=`git rev-parse --verify --short HEAD 2> /dev/null`
> > +        printf "%s%s%s" $sdkversion +g $head > ${S}/.scmversion
> > +    fi
> > +}
> 
> We have similar code in linux-imx.inc; I think we ought to move this to a
> fsl-kernel-localversion.bbclass file to avoid duplicating the logic here.
> I can work on this if you want.
[Luo Zhenhua-B19537] Please go ahead. 

> > +DEPENDS_append = " libgcc"
> > +KERNEL_CC_append = " ${TOOLCHAIN_OPTIONS}"
> > +KERNEL_LD_append = " ${TOOLCHAIN_OPTIONS}"
> 
> Seems very wrong. What the reasion for this?
[Luo Zhenhua-B19537] This code is useless and will be dropped. 

> 
> > +SRCBRANCH = "ls1-dev"
> > +SRCREV = "de1cb4b3c16be38cf3981fd0afa143ad24283d07"
> > +
> > +COMPATIBLE_MACHINE = "(ls1021aqds|ls1021atwr)"
> 
> I'd use the SoC family here.
[Luo Zhenhua-B19537] will use SoC family. 


Best Regards,

Zhenhua