[meta-freescale] [meta-fsl-arm][PATCH v2 1/6] Add common configure files for Layerscape1 support

[Otavio Salvador]

On Wed, Aug 27, 2014 at 1:57 AM, Zhenhua Luo <zhenhua.luo at freescale.com> wrote:
> * conf/machine/include/fsl-ls-default-providers.inc
> * conf/machine/include/fsl-ls-default-settings.inc
> * conf/machine/include/fsl-ls-default-versions.inc

Please let's get these included in ls-base.inc. I plan to get rid of
similar files from imx very soon as it is easier to spot the values if
you have it on the family's file.

> * conf/machine/include/ls-base.inc
>
> Signed-off-by: Zhenhua Luo <zhenhua.luo at freescale.com>

Also the commit log needs rework:

ls-base.inc: Add base configuration for Layerspace1 support

<small description of what this includes>

Signed-of-by: ...

> ---
>  conf/machine/include/fsl-ls-default-providers.inc |  6 ++++++
>  conf/machine/include/fsl-ls-default-settings.inc  |  4 ++++
>  conf/machine/include/fsl-ls-default-versions.inc  |  2 ++
>  conf/machine/include/ls-base.inc                  | 20 ++++++++++++++++++++
>  4 files changed, 32 insertions(+)
>  create mode 100644 conf/machine/include/fsl-ls-default-providers.inc
>  create mode 100644 conf/machine/include/fsl-ls-default-settings.inc
>  create mode 100644 conf/machine/include/fsl-ls-default-versions.inc
>  create mode 100644 conf/machine/include/ls-base.inc
>
> diff --git a/conf/machine/include/fsl-ls-default-providers.inc b/conf/machine/include/fsl-ls-default-providers.inc
> new file mode 100644
> index 0000000..827124c
> --- /dev/null
> +++ b/conf/machine/include/fsl-ls-default-providers.inc
> @@ -0,0 +1,6 @@
> +# Freescale BSP default providers
> +
> +PREFERRED_PROVIDER_u-boot_ls102xa ?= "u-boot-ls1"
> +PREFERRED_PROVIDER_virtual/bootloader_ls102xa ?= "u-boot-ls1"
> +PREFERRED_PROVIDER_virtual/kernel_ls102xa ?= "linux-ls1"

Please move to ls-base.inc.

> diff --git a/conf/machine/include/fsl-ls-default-settings.inc b/conf/machine/include/fsl-ls-default-settings.inc
> new file mode 100644
> index 0000000..45ca43a
> --- /dev/null
> +++ b/conf/machine/include/fsl-ls-default-settings.inc
> @@ -0,0 +1,4 @@
> +# Freescale BSP default settings
> +
> +IMAGE_CLASSES = "image_types_uboot"

Does ALL machines using ls going to use this? I'd prefer this to be in
machine file.

> diff --git a/conf/machine/include/fsl-ls-default-versions.inc b/conf/machine/include/fsl-ls-default-versions.inc
> new file mode 100644
> index 0000000..ddfaf52
> --- /dev/null
> +++ b/conf/machine/include/fsl-ls-default-versions.inc
> @@ -0,0 +1,2 @@
> +# Freescale BSP default versions

Drop.

> diff --git a/conf/machine/include/ls-base.inc b/conf/machine/include/ls-base.inc
> new file mode 100644
> index 0000000..567f55f
> --- /dev/null
> +++ b/conf/machine/include/ls-base.inc
> @@ -0,0 +1,20 @@
> +# Provides the Layerscape common settings
> +
> +include conf/machine/include/fsl-ls-default-settings.inc
> +include conf/machine/include/fsl-ls-default-versions.inc
> +include conf/machine/include/fsl-ls-default-providers.inc

Drop as its content will be here.

> +require conf/machine/include/soc-family.inc
> +
> +UBOOT_ENTRYPOINT_ls102xa = "0x80008000"
> +
> +MACHINE_FEATURES = "pci ext2 ext3 serial"
> +MACHINE_EXTRA_RRECOMMENDS = "u-boot udev-extraconf"

u-boot should be a dependency of the image, not added in all machines.

> +KERNEL_IMAGETYPE ?= "uImage"

Ok.

> +SERIAL_CONSOLES ?= "115200;ttyS0 115200;ttyS1 115200;ttyEHV0 115200;ttyLP0"
> +SERIAL_CONSOLES_CHECK ?= "${SERIAL_CONSOLES}"

Those ought to be in machine files. This vary from one machine to another.

> +USE_VT ?= "0"

This is default.

> +DEFAULTTUNE_ls102xa = "cortexa7hf-neon"

Ok.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750