[meta-freescale] [meta-fsl-arm][PATCH v2 1/2] libmcc: remove bashism in Makefile

Tony Felice tony.felice at timesys.com
Thu Aug 14 10:20:39 PDT 2014


These two patches look fine to me.

-Tony

On 08/14/2014 11:52 AM, Max Krummenacher wrote:
> Replacing bash brace expansion with a Posix compliant syntax to make
> do_install succeed also when using a dash shell.
>
> Signed-off-by: Max Krummenacher <max.oss.09 at gmail.com>
> ---
>   recipes-bsp/libmcc/libmcc/remove_bashisms.patch | 19 +++++++++++++++++++
>   recipes-bsp/libmcc/libmcc_1.04.bb               |  3 ++-
>   2 files changed, 21 insertions(+), 1 deletion(-)
>   create mode 100644 recipes-bsp/libmcc/libmcc/remove_bashisms.patch
>
> diff --git a/recipes-bsp/libmcc/libmcc/remove_bashisms.patch b/recipes-bsp/libmcc/libmcc/remove_bashisms.patch
> new file mode 100644
> index 0000000..87f9866
> --- /dev/null
> +++ b/recipes-bsp/libmcc/libmcc/remove_bashisms.patch
> @@ -0,0 +1,19 @@
> +Replacing bash brace expansion with a Posix compliant syntax to make
> +do_install succeed also when using a dash shell.
> +
> +Upstream-Status: Pending
> +
> +Signed-off-by: Max Krummenacher <max.oss.09 at gmail.com>
> +--- libmcc-1.04/Makefile.orig	2014-08-09 11:17:24.006935887 +0200
> ++++ libmcc-1.04/Makefile	2014-08-09 11:19:36.867546971 +0200
> +@@ -11,8 +11,8 @@
> + 	$(CC) -shared -o $@  $<
> +
> + install:
> +-	mkdir -p $(DESTDIR)/usr/{lib,include}
> +-	cp -f build/libmcc.{so.*,a} $(DESTDIR)/usr/lib
> ++	mkdir -p $(DESTDIR)/usr/include $(DESTDIR)/usr/lib
> ++	cp -f build/libmcc.so.* build/libmcc.a $(DESTDIR)/usr/lib
> + 	cp -f include/*.h $(DESTDIR)/usr/include
> + 	cd $(DESTDIR)/usr/lib/
> + 	ln -sf libmcc.so.1.0 libmcc.so.1
> diff --git a/recipes-bsp/libmcc/libmcc_1.04.bb b/recipes-bsp/libmcc/libmcc_1.04.bb
> index 35efd45..36e082b 100644
> --- a/recipes-bsp/libmcc/libmcc_1.04.bb
> +++ b/recipes-bsp/libmcc/libmcc_1.04.bb
> @@ -7,7 +7,8 @@ DEPENDS = "kernel-module-mcc"
>   
>   inherit autotools
>   
> -SRC_URI = "http://repository.timesys.com/buildsources/l/libmcc/libmcc-${PV}/libmcc-${PV}.tar.bz2"
> +SRC_URI = "http://repository.timesys.com/buildsources/l/libmcc/libmcc-${PV}/libmcc-${PV}.tar.bz2 \
> +           file://remove_bashisms.patch "
>   
>   SRC_URI[md5sum] = "e93ce76b4419f0902a848e1769bf22ea"
>   SRC_URI[sha256sum] = "3de76c5b1a096021afebfc79ca4e85d05646beb3101edcecf73b82886e7a00c0"

-- 
Tony Felice
Vybrid Technical Lead
Timesys Corporation



More information about the meta-freescale mailing list