[meta-freescale] [meta-fsl-arm PATCH 4/4] mxs-base.inc: Add default settings for UBI filesystem generation

[Otavio Salvador]

On Wed, Sep 18, 2013 at 9:58 AM, Daiane Angolini <daiane.list at gmail.com> wrote:
> On Wed, Sep 18, 2013 at 9:32 AM, Eric Bénard <eric at eukrea.com> wrote:
>> Hi Otavio,
>>
>> Le Wed, 18 Sep 2013 09:23:22 -0300,
>> Otavio Salvador <otavio at ossystems.com.br> a écrit :
>>
>>> On Tue, Sep 17, 2013 at 7:10 PM, Eric Bénard <eric at eukrea.com> wrote:
>>> > Hi Otavio,
>>> >
>>> > Le Tue, 17 Sep 2013 18:30:34 -0300,
>>> > Otavio Salvador <otavio at ossystems.com.br> a écrit :
>>> >
>>> >>  physical eraseblock size = 256KiB
>>> >>  logical eraseblock size = 258048
>>> >>  smallest flash I/O unit = 2048
>>> >>  VID header offset = 2048
>>> >>  available PEB = 966
>>> >>
>>> >> For a more detailed howto, please see
>>> >> https://community.freescale.com/docs/DOC-1579
>>> >>
>>> >> Change-Id: I7f6d74064f62e53d21a66417fef95c22e9996d4d
>>> >> Signed-off-by: Otavio Salvador <otavio at ossystems.com.br>
>>> >> ---
>>> >>  conf/machine/include/mxs-base.inc | 3 +++
>>> >>  1 file changed, 3 insertions(+)
>>> >>
>>> >> diff --git a/conf/machine/include/mxs-base.inc b/conf/machine/include/mxs-base.inc
>>> >> index c0681f7..9d16d20 100644
>>> >> --- a/conf/machine/include/mxs-base.inc
>>> >> +++ b/conf/machine/include/mxs-base.inc
>>> >> @@ -25,4 +25,7 @@ XSERVER = "xserver-xorg \
>>> >>  # Ship kernel modules
>>> >>  MACHINE_EXTRA_RRECOMMENDS = "kernel-modules"
>>> >>
>>> >> +MKUBIFS_ARGS = "-m 2048 -e 129024 -c 2030"
>>> >> +UBINIZE_ARGS = "-m 2048 -p 128KiB -s 512"
>>> >> +
>>> > Did you really test this on a mxs based board ?
>>> > If yes with which CPU and which NAND flash ?
>>> >
>>> > At least one parameter (-s 512) is not synchronous with the log you
>>> > provide in the comment.
>>> >
>>> > Moreover these settings are CPU and NAND flash dependent so I don't
>>> > think they belong to mxs-base.inc but to each board file according to
>>> > the flash which is populated.
>>>
>>> Agreed.  I will send a new version of this.
>>>
>>> I had this for loooooong time in my queue and I recall to try it, but
>>> not lately. I will also extend the commit log and move it to mx28evk
>>> board.
>>>
>> no these values are wrong as they come from an i.MX35 tutorial so that
>> won't work on an i.MX28EVK (moreover this board hasn't any NAND
>> populated by default so the values will depend on the NAND flash the
>> user puts in the socket - here I tested with 2k and 4k flashes).
>>
>> So if you can't test it please don't add default values.
>
> If not use default values, what do you suggest?
>
> Even if we can test it (I think I have access to one NAND to attach on imx28)
> it will be only *one* NAND
>
> We have this problem for, at least, all auto/ARD boards.

I think we ought to have the default values; we ought to include the
part number we use for the test in commit log and in a comment next to
     the params but we must have a default.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750