[meta-freescale] [meta-fsl-ppc][PATCH] linux-qoriq-sdk : add config fragments with merge_config.sh from kernel tree

[Luo Zhenhua-B19537]

I think the intention is to use the merge_config.sh provided by built kernel, so the dependency is not needed anymore. 

The merge_config.sh provided by kern-tools-native and built kernel might be different. The change should make senses. 


Best Regards,

Zhenhua

> -----Original Message-----
> From: meta-freescale-bounces at yoctoproject.org [mailto:meta-freescale-
> bounces at yoctoproject.org] On Behalf Of Otavio Salvador
> Sent: Friday, October 18, 2013 11:12 PM
> To: Guo Chunrong-B40290
> Cc: meta-freescale at yoctoproject.org
> Subject: Re: [meta-freescale] [meta-fsl-ppc][PATCH] linux-qoriq-sdk : add
> config fragments with merge_config.sh from kernel tree
> 
> On Fri, Oct 18, 2013 at 3:23 AM,  <b40290 at freescale.com> wrote:
> > From: Chunrong Guo <B40290 at freescale.com>
> >
> > Signed-off-by: Chunrong Guo <B40290 at freescale.com>
> 
> Nack!
> 
> >  recipes-kernel/linux/linux-qoriq-sdk.bb |    6 +++---
> >  1 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/recipes-kernel/linux/linux-qoriq-sdk.bb b/recipes-
> kernel/linux/linux-qoriq-sdk.bb
> > index b7ca721..df18cfe 100644
> > --- a/recipes-kernel/linux/linux-qoriq-sdk.bb
> > +++ b/recipes-kernel/linux/linux-qoriq-sdk.bb
> > @@ -11,7 +11,7 @@ SRC_URI += "file://libtraceevent-Remove-hard-coded-
> include-to-usr-local-include-
> >
> >  PR = "${INC_PR}.1"
> >
> > -DEPENDS_append = " libgcc kern-tools-native"
> > +DEPENDS_append = " libgcc"
> 
> This seems completely wrong. Have you tried this using a clean 'tmp'
> directory? I think it'd fail.
> 
> >  KERNEL_CC_append = " ${TOOLCHAIN_OPTIONS}"
> >  KERNEL_LD_append = " ${TOOLCHAIN_OPTIONS}"
> >
> > @@ -20,8 +20,8 @@ do_configure_prepend() {
> >         cp ${KERNEL_DEFCONFIG} ${B}/.config
> >
> >         # add config fragments
> > -       if [ -a "${DELTA_KERNEL_DEFCONFIG}" ]; then
> > -               merge_config.sh -m .config ${DELTA_KERNEL_DEFCONFIG}
> > +       if [ -f "${DELTA_KERNEL_DEFCONFIG}" ]; then
> > +               ${S}/scripts/kconfig/merge_config.sh -m .config
> ${DELTA_KERNEL_DEFCONFIG}
> >         fi
> >
> >         # append sdk version in kernel version if SDK_VERSION is
> defined
> > --
> > 1.7.5.4
> >
> >
> > _______________________________________________
> > meta-freescale mailing list
> > meta-freescale at yoctoproject.org
> > https://lists.yoctoproject.org/listinfo/meta-freescale
> 
> 
> 
> --
> Otavio Salvador                             O.S. Systems
> http://www.ossystems.com.br        http://code.ossystems.com.br
> Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
> _______________________________________________
> meta-freescale mailing list
> meta-freescale at yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-freescale