[meta-freescale] [meta-fsl-ppc][PATCH v2 3/6] udev-extraconf: add rules from udev

Otavio Salvador otavio at ossystems.com.br
Fri Mar 8 05:32:39 PST 2013


Hello,

On Fri, Mar 8, 2013 at 6:42 AM,  <b28495 at freescale.com> wrote:
> From: Ting Liu <b28495 at freescale.com>
>
> Points from Otavio Salvador [otavio at ossystems.com.br]:
> | These rules should go to udev-extraconf due following reasons:
> | * adding it to udev makes it MACHINE_ARCH specific (hurts build time)
> | * udev-extraconf does fit well for this case
> | * udev-extraconf is much smaller to build (so fast build time)
>
> Signed-off-by: Ting Liu <b28495 at freescale.com>

Please change the commit log; the commit log ought to explain the
change and why it has been done. I understand you reused my comments
for it but it does not fit there. The file ought to be put inside
udev-extraconf directory so you can drop the override to find the
file.

-- 
Otavio Salvador                             O.S. Systems
E-mail: otavio at ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br



More information about the meta-freescale mailing list