[meta-freescale] [meta-fsl-ppc master 3/4] qemu: configure properly check if -lrt is needed

[Liu Ting-B28495]

> -----Original Message-----
> From: Matthew McClintock [mailto:msm-oss at mcclintock.net]
> Sent: Wednesday, March 06, 2013 3:13 PM
> To: McClintock Matthew-B29882
> Cc: Liu Ting-B28495; McClintock Matthew-B29882; meta-
> freescale at yoctoproject.org; Yoder Stuart-B08248; Otavio Salvador
> Subject: Re: [meta-freescale] [meta-fsl-ppc master 3/4] qemu: configure
> properly check if -lrt is needed
> 
> On Fri, Mar 1, 2013 at 12:01 AM, Matthew McClintock <msm at freescale.com>
> wrote:
> > On Fri, Mar 1, 2013 at 12:01 AM, Liu Ting-B28495 <B28495 at freescale.com>
> wrote:
> >>> -----Original Message-----
> >>> From: McClintock Matthew-B29882
> >>> Sent: Friday, March 01, 2013 1:11 PM
> >>> To: Liu Ting-B28495
> >>> Cc: Luo Zhenhua-B19537; Yoder Stuart-B08248; McClintock
> >>> Matthew-B29882; Otavio Salvador; meta-freescale at yoctoproject.org
> >>> Subject: Re: [meta-freescale] [meta-fsl-ppc master 3/4] qemu:
> >>> configure properly check if -lrt is needed
> >>>
> >>> On Thu, Feb 28, 2013 at 11:05 PM, Liu Ting-B28495
> >>> <B28495 at freescale.com>
> >>> wrote:
> >>> >> -----Original Message-----
> >>> >> From: Luo Zhenhua-B19537
> >>> >> Sent: Friday, March 01, 2013 11:41 AM
> >>> >> To: Yoder Stuart-B08248; McClintock Matthew-B29882; Otavio
> >>> >> Salvador; Liu
> >>> >> Ting-B28495
> >>> >> Cc: meta-freescale at yoctoproject.org
> >>> >> Subject: RE: [meta-freescale] [meta-fsl-ppc master 3/4] qemu:
> >>> >> configure properly check if -lrt is needed
> >>> >>
> >>> >> Add Ting for comment.
> >>> >>
> >>> >>
> >>> >> Best Regards,
> >>> >>
> >>> >> Zhenhua
> >>> >>
> >>> >>
> >>> >> > -----Original Message-----
> >>> >> > From: Yoder Stuart-B08248
> >>> >> > Sent: Friday, March 01, 2013 4:11 AM
> >>> >> > To: McClintock Matthew-B29882; Otavio Salvador
> >>> >> > Cc: Luo Zhenhua-B19537; meta-freescale at yoctoproject.org
> >>> >> > Subject: RE: [meta-freescale] [meta-fsl-ppc master 3/4] qemu:
> >>> >> > configure properly check if -lrt is needed
> >>> >> >
> >>> >> >
> >>> >> >
> >>> >> > > -----Original Message-----
> >>> >> > > From: McClintock Matthew-B29882
> >>> >> > > Sent: Thursday, February 28, 2013 9:22 AM
> >>> >> > > To: Otavio Salvador; Yoder Stuart-B08248
> >>> >> > > Cc: Luo Zhenhua-B19537; meta-freescale at yoctoproject.org
> >>> >> > > Subject: Re: [meta-freescale] [meta-fsl-ppc master 3/4] qemu:
> >>> >> > > configure properly check if -lrt is needed
> >>> >> > >
> >>> >> > > On Thu, Feb 28, 2013 at 6:27 AM, Otavio Salvador
> >>> >> > > <otavio at ossystems.com.br> wrote:
> >>> >> > > > On Thu, Feb 28, 2013 at 5:54 AM, Zhenhua Luo
> >>> >> > <zhenhua.luo at freescale.com> wrote:
> >>> >> > > >> From: Ting Liu <b28495 at freescale.com>
> >>> >> > > >>
> >>> >> > > >> Back port from:
> >>> >> > > >> http://git.qemu.org/?p=qemu.git;a=commit;h=8bacde8d86a0969
> >>> >> > > >> 9207
> >>> >> > > >> d85
> >>> >> > > >> d4
> >>> >> > > >> bab06162aed18dc4
> >>> >> > > >>
> >>> >> > > >> Fix the below build issue:
> >>> >> > > >> | ../qemu-timer.o: In function `dynticks_rearm_timer':
> >>> >> > > >> | .../qemu/1.0+fsl-r2/git/qemu-timer.c:597: undefined
> >>> >> > > >> | reference to
> >>> >> > `timer_gettime'
> >>> >> > > >> | .../qemu/1.0+fsl-r2/git/qemu-timer.c:610: undefined
> >>> >> > > >> | reference to
> >>> >> > `timer_settime'
> >>> >> > > >> | ../qemu-timer.o: In function `dynticks_stop_timer':
> >>> >> > > >> | .../qemu/1.0+fsl-r2/git/qemu-timer.c:583: undefined
> >>> >> > > >> | reference to
> >>> >> > `timer_delete'
> >>> >> > > >> | ../qemu-timer.o: In function `dynticks_start_timer':
> >>> >> > > >> | .../qemu/1.0+fsl-r2/git/qemu-timer.c:565: undefined
> >>> >> > > >> | reference to
> >>> >> > `timer_create'
> >>> >> > > >> | ivshmem.o: In function `pci_ivshmem_init':
> >>> >> > > >> | .../qemu/1.0+fsl-r2/git/hw/ivshmem.c:720: undefined
> >>> >> > > >> | reference to
> >>> >> > `shm_open'
> >>> >> > > >> | .../qemu/1.0+fsl-r2/git/hw/ivshmem.c:727: undefined
> >>> >> > > >> | reference to
> >>> >> > `shm_open'
> >>> >> > > >> | collect2: error: ld returned 1 exit status
> >>> >> > > >> | make[1]: *** [qemu-system-ppc] Error 1
> >>> >> > > >> | make: *** [subdir-ppc-softmmu] Error 2
> >>> >> > > >> | ERROR: oe_runmake failed
> >>> >> > > >> | ERROR: Function failed: do_compile
> >>> >> > > >>
> >>> >> > > >> Signed-off-by: Ting Liu <b28495 at freescale.com>
> >>> >> > > >
> >>> >> > > > Good.
> >>> >> > >
> >>> >> > > Did we check with Staurt to see if we can get him to add this
> >>> >> > > patch to his tree at git.freescale.com?
> >>> >> >
> >>> >> > I don't understand the changes and why they are needed.
> >>> >> >
> >>> >> > Also, we are getting ready to up-rev to QEMU 1.4 and so things
> >>> >> > may
> >>> >> change.
> >>> >> > If this is a blocking issue and you want to hack this code to
> make
> >>> >> > progress on rebasing Yocto, fine.   But realize that we are
> going to
> >>> >> > uprev QEMU and things are going to change.
> >>> >> >
> >>> >
> >>> > This issue only appeared when we rebased poky onto 1.4_M4
> >>> > recently,
> >>> with our own qemu tree released for SDK 1.3. if we are going to use
> >>> qemu 1.4, I think this issue will go away. But before that, we need
> >>> this patch to not block yocto build tests.
> >>>
> >>> Seems like some library or toolchain changed in poky that is causing
> >>> this issue. I tend to thing we should apply this patch and carry on
> >>> and and move to qemu 1.4 as soon as it's available. Although it
> >>> would be nice if the commit had a bit more information about what's
> actually going on.
> >>>
> >>
> >> Maybe add one line:
> >> -lrt is needed to avoid the error "undefined reference to
> `timer_settime'". add the check in configure.
> >>
> >> Yocto 1.4_M4 uses qemu 1.3.1 which includes this fix. So this issue
> only appeared to us.
> >
> > Add the two lines ;)
> 
> Waiting on new patch with these two lines in the commit message.
> Marking patch rejected.
> 

Patch v2 been sent yesterday. Please review.

-Ting

> -M