[meta-freescale] [meta-fsl-ppc 36/42] oprofile: Include config.h before bfd.h

[Liu Ting-B28495]

> -----Original Message-----
> From: McClintock Matthew-B29882
> Sent: Thursday, January 31, 2013 2:50 PM
> To: Luo Zhenhua-B19537; Liu Ting-B28495
> Cc: McClintock Matthew-B29882; meta-freescale at yoctoproject.org
> Subject: Re: [meta-freescale] [meta-fsl-ppc 36/42] oprofile: Include
> config.h before bfd.h
> 
> Adding Ting
> 
> -M
> 
> On Thu, Jan 31, 2013 at 12:29 AM, Luo Zhenhua-B19537
> <B19537 at freescale.com> wrote:
> > Since oprofile-0.9.8(in oe-core) will be used, the patches are not
> needed anymore.
> >

The patch can be dropped if we use oprofile-0.9.8(in oe-core).

-Ting

> > Ting, please correct me if any misunderstanding.
> >
> >
> > Best Regards,
> >
> > Zhenhua
> >
> >
> >> -----Original Message-----
> >> From: McClintock Matthew-B29882
> >> Sent: Thursday, January 31, 2013 7:16 AM
> >> To: Luo Zhenhua-B19537
> >> Cc: meta-freescale at yoctoproject.org; McClintock Matthew-B29882
> >> Subject: Re: [meta-freescale] [meta-fsl-ppc 36/42] oprofile: Include
> >> config.h before bfd.h
> >>
> >> On Wed, Jan 30, 2013 at 2:51 AM, Zhenhua Luo
> >> <zhenhua.luo at freescale.com>
> >> wrote:
> >> > From: Ting Liu <b28495 at freescale.com>
> >> >
> >> > oprofile uses bfd.h from binutils which now in 2.23+ expects
> >> > config.h so lets include it
> >> >
> >> > (From OE-Core rev: cd7aa7440103284a47b96ec176cace8685f720bb)
> >> > (From poky rev: 0333796a6b167dd754806700d7f771dd4a74e4ab)
> >>
> >> Do we really need this in master meta-fsl-ppc? It looks like a
> >> backport of a oe-core patch for denzil or something similiar?
> >>

Yes, it is a backport to fix build issue in master as binutils upgraded.

-Ting

> >> -M
> >>
> >> >
> >> > Signed-off-by: Ting Liu <b28495 at freescale.com>
> >> > ---
> >> >  .../oprofile/oprofile/fix-bfd-include.patch        |   66
> >> ++++++++++++++++++++
> >> >  1 file changed, 66 insertions(+)
> >> >  create mode 100644
> >> > recipes-kernel/oprofile/oprofile/fix-bfd-include.patch
> >> >
> >> > diff --git a/recipes-kernel/oprofile/oprofile/fix-bfd-include.patch
> >> > b/recipes-kernel/oprofile/oprofile/fix-bfd-include.patch
> >> > new file mode 100644
> >> > index 0000000..944320f
> >> > --- /dev/null
> >> > +++ b/recipes-kernel/oprofile/oprofile/fix-bfd-include.patch
> >> > @@ -0,0 +1,66 @@
> >> > +bfd.h now wants to include autotools generated config.h for
> >> > +reasoning read
> >> > +http://sourceware.org/bugzilla/show_bug.cgi?id=14243
> >> > +
> >> > +Signed-off-by: Khem Raj <raj.khem at gmail.com>
> >> > +
> >> > +Upstream-Status: Pending
> >> > +Index: oprofile-0.9.7/libutil++/bfd_support.h
> >> > +===================================================================
> >> > +--- oprofile-0.9.7.orig/libutil++/bfd_support.h        2011-07-04
> >> 19:25:04.000000000 -0700
> >> > ++++ oprofile-0.9.7/libutil++/bfd_support.h     2012-12-02
> >> 10:51:23.518784249 -0800
> >> > +@@ -11,6 +11,7 @@
> >> > + #ifndef BFD_SUPPORT_H
> >> > + #define BFD_SUPPORT_H
> >> > +
> >> > ++#include "config.h"
> >> > + #include "utility.h"
> >> > + #include "op_types.h"
> >> > + #include "locate_images.h"
> >> > +Index: oprofile-0.9.7/libopagent/opagent.c
> >> > +===================================================================
> >> > +--- oprofile-0.9.7.orig/libopagent/opagent.c   2011-07-04
> >> 19:25:04.000000000 -0700
> >> > ++++ oprofile-0.9.7/libopagent/opagent.c        2012-12-02
> >> 10:58:10.954804150 -0800
> >> > +@@ -50,6 +50,7 @@
> >> > +  *   See libopagent/Makefile.am for more information.
> >> > +
> >> > +******************************************************************
> >> > +*/
> >> > +
> >> > ++#include "config.h"
> >> > + #include <stdio.h>
> >> > + #include <errno.h>
> >> > + #include <string.h>
> >> > +Index: oprofile-0.9.7/libpp/symbol.h
> >> > +==================================================================
> >> > +=
> >> > +--- oprofile-0.9.7.orig/libpp/symbol.h 2011-07-04
> >> > +19:25:04.000000000 -0700
> >> > ++++ oprofile-0.9.7/libpp/symbol.h      2012-12-02
> 10:59:59.434809273 -
> >> 0800
> >> > +@@ -18,6 +18,7 @@
> >> > + #include "format_flags.h"
> >> > + #include "op_types.h"
> >> > +
> >> > ++#include "config.h"
> >> > + #include <bfd.h>
> >> > + #include <stdint.h>
> >> > +
> >> > +Index: oprofile-0.9.7/opjitconv/debug_line.c
> >> > +==================================================================
> >> > +=
> >> > +--- oprofile-0.9.7.orig/opjitconv/debug_line.c 2011-07-04
> >> > +19:25:04.000000000 -0700
> >> > ++++ oprofile-0.9.7/opjitconv/debug_line.c      2012-12-02
> >> 11:02:26.046816339 -0800
> >> > +@@ -8,6 +8,7 @@
> >> > +  * @author Philippe Elie
> >> > +  */
> >> > +
> >> > ++#include "config.h"
> >> > + #include <stdint.h>
> >> > + #include <stdlib.h>
> >> > + #include <string.h>
> >> > +Index: oprofile-0.9.7/opjitconv/opjitconv.h
> >> > +==================================================================
> >> > +=
> >> > +--- oprofile-0.9.7.orig/opjitconv/opjitconv.h  2011-07-04
> >> > +19:25:04.000000000 -0700
> >> > ++++ oprofile-0.9.7/opjitconv/opjitconv.h       2012-12-02
> >> 11:01:25.558813373 -0800
> >> > +@@ -26,6 +26,7 @@
> >> > + #define OP_JIT_CONV_ALREADY_DONE 5  #define
> >> > +OP_JIT_CONV_TMPDIR_NOT_REMOVED 6
> >> > +
> >> > ++#include "config.h"
> >> > + #include <bfd.h>
> >> > + #include <stddef.h>
> >> > + #include <sys/stat.h>
> >> > --
> >> > 1.7.9.5
> >> >
> >> >
> >> > _______________________________________________
> >> > meta-freescale mailing list
> >> > meta-freescale at yoctoproject.org
> >> > https://lists.yoctoproject.org/listinfo/meta-freescale
> >
> > _______________________________________________
> > meta-freescale mailing list
> > meta-freescale at yoctoproject.org
> > https://lists.yoctoproject.org/listinfo/meta-freescale