[meta-freescale] [meta-fsl-arm][PATCH 3/4] glproto: Don't install glxtokens.h for imx6qsabrelite

[Eric Bénard]

Le Thu, 24 Jan 2013 20:26:31 +0200,
Andrei Gherzan <andrei at gherzan.ro> a écrit :

> On Thu, Jan 24, 2013 at 8:23 PM, Eric Bénard <eric at eukrea.com> wrote:
> 
> > Le Thu, 24 Jan 2013 16:05:46 -0200,
> > Otavio Salvador <otavio at ossystems.com.br> a écrit :
> >
> > > On Thu, Jan 24, 2013 at 4:01 PM, Eric Bénard <eric at eukrea.com> wrote:
> > > > Hi Andrai,
> > > >
> > > > Le Thu, 24 Jan 2013 19:50:42 +0200,
> > > > Andrei Gherzan <andrei at gherzan.ro> a écrit :
> > > >
> > > >> On Mon, Jan 14, 2013 at 3:22 PM, Eric Bénard <eric at eukrea.com> wrote:
> > > >>
> > > >> > Le Mon, 14 Jan 2013 15:01:21 +0200,
> > > >> > Andrei Gherzan <andrei at gherzan.ro> a écrit :
> > > >> >
> > > >> > > On Mon, Jan 14, 2013 at 2:25 PM, Otavio Salvador <
> > > >> > otavio at ossystems.com.br>wrote:
> > > >> > >
> > > >> > > > On Mon, Jan 14, 2013 at 10:22 AM, Andrei Gherzan <
> > andrei at gherzan.ro>
> > > >> > > > wrote:
> > > >> > > > > On Mon, Jan 14, 2013 at 1:55 PM, Otavio Salvador <
> > > >> > > > otavio at ossystems.com.br>
> > > >> > > > > wrote:
> > > >> > > > >>
> > > >> > > > >> On Sun, Jan 13, 2013 at 2:28 PM, Andrei Gherzan
> > > >> > > > >> <andrei.gherzan at windriver.com> wrote:
> > > >> > > > >> > Avoid in this way duplicate file warnings in sysroot.
> > > >> > > > >> > This header is provided by freescale.
> > > >> > > > >> >
> > > >> > > > >> > Signed-off-by: Andrei Gherzan <
> > andrei.gherzan at windriver.com>
> > > >> > > > >>
> > > >> > > > >> Wouldn't be better to use the one provided by Xorg and drop
> > the one
> > > >> > in
> > > >> > > > >> the GPU package?
> > > >> > > > >
> > > >> > > > >
> > > >> > > > > Xorg? Is Xorg bringing that header too?
> > > >> > > >
> > > >> > >
> > > >> > > I know and I understand now. Well... don't know what to say. My
> > opinion
> > > >> > > would be to use the ones from GPU. After all those are HW
> > dependent isn't
> > > >> > > it?
> > > >> >
> > > >> > what is the diff between both files ?
> > > >> >
> > > >>
> > > >> Here (http://paste.ubuntu.com/1566706/) is the diff from proto
> > version and
> > > >> viv version. Seems like a lot of viv specific changes. Take a look.
> > > >>
> > > > OK so it may be better to use the one of the GPU package and not the
> > > > one from Xorg.
> > >
> > > Right but then we need to change the header name and patch the code to
> > > use it; so both won't conflict.
> > >
> > or to exclude the header for the Xorg package and package this one
> > instead.
> >
> 
> This patch does this.
> 
I was just asking the diff to get an answer to Otavio's question
"Wouldn't be better to use the one provided by Xorg and drop the one in
the GPU package?"

So it seems your patch is the right thing to do and that was difficult
to give an opinion without seeing a diff.

Eric