[meta-freescale] [meta-fsl-arm-extra][PATCH] Enable USB gadget, and disable lockdep debugging to avoid the warning

Otavio Salvador otavio at ossystems.com.br
Sun Dec 29 21:24:11 PST 2013


On Mon, Dec 23, 2013 at 11:17 AM, Alexandre Belloni
<alexandre.belloni at free-electrons.com> wrote:
> On 23/12/2013 13:54, Daiane.Angolini at freescale.com wrote:
>>> -----Original Message-----
>>> From: meta-freescale-bounces at yoctoproject.org [mailto:meta-freescale-
>>> bounces at yoctoproject.org] On Behalf Of Alexandre Belloni
>>> Sent: Friday, December 20, 2013 4:16 PM
>>> To: meta-freescale at yoctoproject.org
>>> Cc: Maxime Ripard
>>> Subject: [meta-freescale] [meta-fsl-arm-extra][PATCH] Enable USB gadget,
>>> and disable lockdep debugging to avoid the warning
>>>
>>> From: Maxime Ripard <maxime.ripard at free-electrons.com>
>>>
>>> Signed-off-by: Maxime Ripard <maxime.ripard at free-electrons.com>
>>> Signed-off-by: Alexandre Belloni <alexandre.belloni at free-electrons.com>
>> Thanks a lot for your patch.
>>
>> Would you mind to add the target machine in commit subject? And include the reason
>> Why you´re doing this patch in commit log?
>>
>> And one more thing. If you have not used savedefconfig to generate the defconfig file, could you, please use it?
> The reason for this patch is actually exactly because we used
> savedefconfig. For CONFIG_USB_GADGET=y, savedefconfig is not saving the
> state and you end up with CONFIG_USB_GADGET=m after applying the
> defconfig which is annoying because we don't have anything to load the
> module before trying the usb ethernet interface.

I think this may be because one of dependencies is using 'm' and
causing Kconfig to tigger the change for 'm'. Please check the
dependencies in Kconfig and do a check.

I do prefer to get trimmed config files as it easy review and
maintenance so I'd not apply this patch as is.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750


More information about the meta-freescale mailing list